From: Jirka Klimes <jklimes@redhat.com>
To: linux-media@vger.kernel.org
Subject: dvb-apps: remove broken and not functional dvbscan
Date: Tue, 26 Jun 2012 09:38:34 +0200 [thread overview]
Message-ID: <1969729.Q46QkrbvB0@gromit> (raw)
dvb-apps' "dvbsca"n from util/dvbscan/ doesn't work. It exits with "Unable to
query frontend status".
By looking into source code I've found there's a bug in
util/dvbscan/dvbscan.c:309 that uses DVBFE_INFO_QUERYTYPE_IMMEDIATE return
value instead of DVBFE_INFO_LOCKSTATUS. However, a further look reveals that
scanning is not actually implemented and according to commit status (just a
few on 2006-11-20) it is evident that the code is abandoned.
I suggest removing the code in favor of util/scan that works OK. The broken
dvbscan in the tree causes confusion as some users don't know there's another
scanning tool that actually works.
Another suggestion is to rename "scan" to "scandvb" otherwise it can collide
with other tools and some distributions rename it thus anyway.
Cheers,
Jirka
reply other threads:[~2012-06-26 7:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1969729.Q46QkrbvB0@gromit \
--to=jklimes@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).