From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] media-device.h: fix compiler warning
Date: Wed, 02 Mar 2016 09:54:14 +0200 [thread overview]
Message-ID: <1978984.NgLd87hx0T@avalon> (raw)
In-Reply-To: <56D00263.8040606@xs4all.nl>
Hi Hans,
Thank you for the patch.
On Friday 26 February 2016 08:44:35 Hans Verkuil wrote:
> Fix these compiler warnings:
>
> media-git/include/media/media-device.h: In function 'media_device_pci_init':
> media-git/include/media/media-device.h:610:9: warning: 'return' with a
> value, in function returning void return NULL;
> ^
> media-git/include/media/media-device.h: In function
> '__media_device_usb_init': media-git/include/media/media-device.h:618:9:
> warning: 'return' with a value, in function returning void return NULL;
> ^
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> diff --git a/include/media/media-device.h b/include/media/media-device.h
> index 49dda6c..44012fe 100644
> --- a/include/media/media-device.h
> +++ b/include/media/media-device.h
> @@ -607,7 +607,6 @@ static inline void media_device_pci_init(struct
> media_device *mdev, struct pci_dev *pci_dev,
> char *name)
> {
> - return NULL;
> }
>
> static inline void __media_device_usb_init(struct media_device *mdev,
> @@ -615,7 +614,6 @@ static inline void __media_device_usb_init(struct
> media_device *mdev, char *board_name,
> char *driver_name)
> {
> - return NULL;
> }
>
> #endif /* CONFIG_MEDIA_CONTROLLER */
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2016-03-02 7:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 7:44 [PATCH] media-device.h: fix compiler warning Hans Verkuil
2016-03-02 7:54 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1978984.NgLd87hx0T@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox