From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] i2c: adv748x: fix typo in comment for TXB CSI-2 transmitter power down
Date: Tue, 18 Sep 2018 13:17:33 +0300 [thread overview]
Message-ID: <1979276.imk8I1T1qk@avalon> (raw)
In-Reply-To: <20180918014509.6394-4-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas,
Thank you for the patch.
On Tuesday, 18 September 2018 04:45:09 EEST Niklas Söderlund wrote:
> Fix copy-and-past error in comment for TXB CSI-2 transmitter power down
> sequence.
Apart from the s/past/paste/ typo that Sergei pointed out, I see no other
issue.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c
> b/drivers/media/i2c/adv748x/adv748x-core.c index
> 9a82cdf301bccb41..86cb38f4d7cc11c6 100644
> --- a/drivers/media/i2c/adv748x/adv748x-core.c
> +++ b/drivers/media/i2c/adv748x/adv748x-core.c
> @@ -299,7 +299,7 @@ static const struct adv748x_reg_value
> adv748x_power_down_txb_1lane[] = {
>
> {ADV748X_PAGE_TXB, 0x31, 0x82}, /* ADI Required Write */
> {ADV748X_PAGE_TXB, 0x1e, 0x00}, /* ADI Required Write */
> - {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 4-lane MIPI */
> + {ADV748X_PAGE_TXB, 0x00, 0x81}, /* Enable 1-lane MIPI */
> {ADV748X_PAGE_TXB, 0xda, 0x01}, /* i2c_mipi_pll_en - 1'b1 */
> {ADV748X_PAGE_TXB, 0xc1, 0x3b}, /* ADI Required Write */
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-09-18 15:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 1:45 [PATCH 0/3] i2c: adv748x: add support for CSI-2 TXA to work in 1-, 2- and 4-lane mode Niklas Söderlund
2018-09-18 1:45 ` [PATCH 1/3] i2c: adv748x: store number of CSI-2 lanes described in device tree Niklas Söderlund
2018-09-18 10:16 ` Laurent Pinchart
2018-09-18 10:19 ` Kieran Bingham
2018-09-18 10:28 ` Laurent Pinchart
2018-09-18 10:37 ` Kieran Bingham
2018-09-18 10:46 ` Laurent Pinchart
2018-09-18 10:51 ` Kieran Bingham
2018-09-18 11:13 ` Laurent Pinchart
2018-09-20 23:43 ` Sakari Ailus
2018-09-21 9:33 ` Dave Stevenson
2018-09-21 10:01 ` Laurent Pinchart
2018-09-21 12:03 ` Sakari Ailus
2018-09-21 13:46 ` Dave Stevenson
2018-11-13 9:40 ` Sakari Ailus
2018-09-21 13:38 ` Dave Stevenson
2018-09-18 19:06 ` Niklas Söderlund
2018-09-18 1:45 ` [PATCH 2/3] i2c: adv748x: configure number of lanes used for TXA CSI-2 transmitter Niklas Söderlund
2018-09-18 10:13 ` Kieran Bingham
2018-09-18 19:29 ` Niklas Söderlund
2018-09-18 20:35 ` Kieran Bingham
2018-09-18 22:50 ` Laurent Pinchart
2018-09-18 22:46 ` Laurent Pinchart
2018-09-18 1:45 ` [PATCH 3/3] i2c: adv748x: fix typo in comment for TXB CSI-2 transmitter power down Niklas Söderlund
2018-09-18 9:10 ` Sergei Shtylyov
2018-09-18 9:54 ` Kieran Bingham
2018-09-18 10:22 ` Kieran Bingham
2018-09-18 12:34 ` jacopo mondi
2018-09-18 16:06 ` Kieran Bingham
2018-09-18 10:17 ` Laurent Pinchart [this message]
2018-09-26 13:49 ` Kieran Bingham
2018-09-26 14:09 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1979276.imk8I1T1qk@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=jacopo@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox