From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:41787 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840AbaFFNll (ORCPT ); Fri, 6 Jun 2014 09:41:41 -0400 From: Laurent Pinchart To: Hans Verkuil Cc: Pawel Osciak , LMML , Nicolas Dufresne , Marek Szyprowski , Kyungmin Park Subject: Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag Date: Fri, 06 Jun 2014 15:42:09 +0200 Message-ID: <1984998.tr3slfZQtz@avalon> In-Reply-To: <53919025.1060407@xs4all.nl> References: <1401970991-4421-1-git-send-email-laurent.pinchart@ideasonboard.com> <1435470.qABIAKhMXR@avalon> <53919025.1060407@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: On Friday 06 June 2014 11:55:49 Hans Verkuil wrote: > On 06/06/2014 11:46 AM, Laurent Pinchart wrote: > > On Friday 06 June 2014 11:31:55 Hans Verkuil wrote: > >> On 06/06/2014 11:19 AM, Laurent Pinchart wrote: > >>> On Friday 06 June 2014 14:31:15 Pawel Osciak wrote: > >>>> Hi Laurent, > >>>> Thanks for the patch. Did you test this to work in fileio mode? Looks > >>>> like it should, but would like to make sure. > >>> > >>> No, I haven't tested it. The OMAP4 ISS driver, which is my test target > >>> for this patch, doesn't support fileio mode. Adding VB2_READ would be > >>> easy, but the driver requires configuring the format on the file handle > >>> used for streaming, so I can't just run cat /dev/video*. > >> > >> Just test with vivi. > > > > But vivi doesn't call the new vb2_queue_error() function. I understand > > that your vivi rework would make that easier as you now have an error > > control. Should I hack something similar in the existing vivi driver ? Any > > pointer ? > > Just hack it in for testing. E.g. call it when the button control is pressed > (see vivi_s_ctrl). Tested-by: Laurent Pinchart "cat /dev/video0" outputs data until vivi calls vb2_queue_error(), at which points cat prints cat: /dev/video0: Input/output error Restarting capture works as expected. -- Regards, Laurent Pinchart