From: Pavel Skripkin <paskripkin@gmail.com>
To: Ammar Faizi <ammar.faizi@students.amikom.ac.id>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Bedirhan KURT <windowz414@gnuweeb.org>
Subject: Re: [PATCH] media: atomisp: fix `-Werror=return-type`
Date: Sun, 3 Oct 2021 19:19:19 +0300 [thread overview]
Message-ID: <1bad16dc-e11e-4096-2014-a0eae92686e8@gmail.com> (raw)
In-Reply-To: <20211002231723.29019-1-ammar.faizi@students.amikom.ac.id>
On 10/3/21 02:17, Ammar Faizi wrote:
> Bedirhan reported build error:
> ```
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> 1649 | }
> | ^
> cc1: some warnings being treated as errors
> make[4]: *** [scripts/Makefile.build:277: drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.o] Error 1
> make[3]: *** [scripts/Makefile.build:540: drivers/staging/media/atomisp] Error 2
> make[2]: *** [scripts/Makefile.build:540: drivers/staging/media] Error 2
> make[1]: *** [scripts/Makefile.build:540: drivers/staging] Error 2
> make: *** [Makefile:1868: drivers] Error 2
> ```
>
> Commit 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp:
> remove useless returns") incorrectly removed a required return results
> in the above build error. Reinstate it.
>
> Cc: Pavel Skripkin <paskripkin@gmail.com>
> Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: linux-media@vger.kernel.org
> Cc: linux-staging@lists.linux.dev
> Cc: linux-kernel@vger.kernel.org
> Reported-by: Bedirhan KURT <windowz414@gnuweeb.org>
> Fixes: 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp: remove useless returns")
> Signed-off-by: Ammar Faizi <ammar.faizi@students.amikom.ac.id>
> ---
> .../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8e085dda0c18..1bd917e81743 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -1646,6 +1646,7 @@ static input_system_err_t input_system_configure_channel_sensor(
> default:
> return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
> }
> + return INPUT_SYSTEM_ERR_NO_ERROR;
> }
>
> // Test flags and set structure.
>
Hi, Ammar!
Thank you for fixing this, but it's already fixed in linux-next tree.
See commit 05344a1d2ea7 ("media: atomisp: restore missing 'return'
statement").
Again, I am sorry for introducing this bug :(
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-10-03 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 23:17 [PATCH] media: atomisp: fix `-Werror=return-type` Ammar Faizi
2021-10-03 16:19 ` Pavel Skripkin [this message]
2021-10-03 23:24 ` Ammar Faizi
2021-10-04 9:05 ` Dan Carpenter
2021-10-04 14:11 ` Ammar Faizi
2021-10-04 14:41 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bad16dc-e11e-4096-2014-a0eae92686e8@gmail.com \
--to=paskripkin@gmail.com \
--cc=ammar.faizi@students.amikom.ac.id \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab+huawei@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=windowz414@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox