Re: [PATCH 4/6] media: qcom: camss: add support for QCM2290 camss

Loic Poulain
2025-04-16T15:16:37Z

On Wed, Apr 16, 2025 at 2:17 PM Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:
>
> On 16/04/2025 13:09, Loic Poulain wrote:
> > The camera subsystem for QCM2290 which is based on Spectra 340.
> >
> > Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> > ---
> > drivers/media/platform/qcom/camss/camss-vfe.c | 2 +
> > drivers/media/platform/qcom/camss/camss.c | 146 ++++++++++++++++++
> > 2 files changed, 148 insertions(+)
> >
> > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> > index 4bca6c3abaff..c575c9767492 100644
> > --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
[...]
> > +
> > +static const struct resources_icc icc_res_2290[] = {
> > + {
> > + .name = "ahb",
> > + .icc_bw_tbl.avg = 150000,
> > + .icc_bw_tbl.peak = 300000,
> > + },
> > + {
> > + .name = "hf_mnoc",
> > + .icc_bw_tbl.avg = 2097152,
> > + .icc_bw_tbl.peak = 2097152,
> > + },
> > + {
> > + .name = "sf_mnoc",
> > + .icc_bw_tbl.avg = 2097152,
> > + .icc_bw_tbl.peak = 2097152,
> > + },
> > +};
>
> I think you can get better numbers from downstream for the above.

So I'm not sure how to get the 'correct' values? I've not executed the
downstream driver to get the output of aggregated votes. The only
clear references I see is: `CAM_CPAS_AXI_MIN_CAMNOC_IB_BW
(3000000000UL)` as well as `camnoc-axi-min-ib-bw = <3000000000>;`
in the devicetree, which would give us 3000000kBps.

Regards,
Loic