Re: [PATCH 6/6] arm64: dts: qcom: qcm2290: Add CAMSS node

Loic Poulain
2025-04-16T16:16:42Z

On Wed, Apr 16, 2025 at 4:46 PM Konrad Dybcio
<konrad.dybcio@oss.qualcomm.com> wrote:
>
> On 4/16/25 2:09 PM, Loic Poulain wrote:
> > Add node for the QCM2290 camera subsystem.
> >
> > Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> > ---
> > arch/arm64/boot/dts/qcom/qcm2290.dtsi | 93 +++++++++++++++++++++++++++
> > 1 file changed, 93 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> > index f0746123e594..4b81e721e50c 100644
> > --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> > @@ -1579,6 +1579,99 @@ adreno_smmu: iommu@59a0000 {
> > #iommu-cells = <2>;
> > };
> >
> > + camss: camss@5c52000 {
>
> @5c6e000
> (first reg entry)
>
> > + compatible = "qcom,qcm2290-camss";
> > +
> > + reg = <0 0x5c6e000 0 0x1000>,
> > + <0 0x5c75000 0 0x1000>,
> > + <0 0x5c52000 0 0x1000>,
> > + <0 0x5c53000 0 0x1000>,
> > + <0 0x5c6f000 0 0x4000>,
> > + <0 0x5c76000 0 0x4000>;
> > + reg-names = "csid0",
> > + "csid1",
> > + "csiphy0",
> > + "csiphy1",
> > + "vfe0",
> > + "vfe1";
>
> we also have a pair of TPGs at 0x5c6[68]000 - I think it would be good to
> describe them from the get-go

If we want to be ready for TPG, we may also want a camss 'top' reg
(0x05C11000), since it seems to be required for configuring CSID input
mux (TPG vs CSIPHY).