Re: [PATCH 6/6] arm64: dts: qcom: qcm2290: Add CAMSS node

Bryan O'Donoghue
2025-04-16T15:03:31Z

On 16/04/2025 16:01, Loic Poulain wrote:
>> @5c6e000
>> (first reg entry)
> Ah right, I reordered reg to be aligned with other camss drivers.
> Should I keep that order (and update node name) or reorder with phy
> lower addresses first (PHYs)?
>
>>> + compatible = "qcom,qcm2290-camss";
>>> +
>>> + reg = <0 0x5c6e000 0 0x1000>,
>>> + <0 0x5c75000 0 0x1000>,
>>> + <0 0x5c52000 0 0x1000>,
>>> + <0 0x5c53000 0 0x1000>,
>>> + <0 0x5c6f000 0 0x4000>,
>>> + <0 0x5c76000 0 0x4000>;
>>> + reg-names = "csid0",
>>> + "csid1",
>>> + "csiphy0",
>>> + "csiphy1",
>>> + "vfe0",
>>> + "vfe1";

Please keep consistent with the last committed yaml for CAMSS.

---
bod