From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 584E833ADB3; Fri, 13 Feb 2026 09:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770974734; cv=none; b=cAxAZqPjmvb6p7iJ//F/N2fpRc0QqvFA8hvrla5PltgaFwUqqGl/B+XQuWbhAnYiVLdcmwOBg+G/wrDLUpv+qHloJZyLJJnMf7H8/9HD2Q2K6HxRL/pe1WmefRmbTXLotHlU8ZaJOnltkgkK0S18YFtKe9R0l3g6QOqlU+UD0RI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770974734; c=relaxed/simple; bh=G5uVfiHvpJL7gGWEE69leLa5qM6BlavB/hM9VB1DZnM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J6njQ6/3MPyHTg4cNkjsydzgxrPWhpbR614J05c6g8T02ygmGohkiwYnt3Hd1/GM4Lj2vuHLmRPhd2Rd4bTJZTXg+Z3RpdMd2KWGPBCD6lZlxgkEtUab6aWSe28fho64/aQyPC6tuIm+8J6E9SwVdLpSEifo9pfSH7AeaK9G2mE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=VTOkrQjJ; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="VTOkrQjJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1770974731; bh=G5uVfiHvpJL7gGWEE69leLa5qM6BlavB/hM9VB1DZnM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=VTOkrQjJfHt53FBmeh4TZceysttLfR6T/agUdUWq8bavGxs1gHSKaS5OamqBMHmAy UQ+JnnfJVwJDdLYdmdfKn4loOzu8y1oNVDqrjZimuck2GrCFSLYnhW1Ig6lR2gxM58 c387nPyYx+gFMcBvfRh3AuXJwFTQQb3NZjcl5Y1+2onXga3PBQcdew4wVb9gttu5vg bOws3sNAXwv138v3CGWVu7J+vip9ZOQbBP8o0MBH3Sj+Dqb588T3FADYS8YXg2zCdo xxRet0yJJ1yEGYBdxDc4bMJN6k8VS43OO/KINDkchQw9P8E6mBeo62UC/1lSMhc+co 0Yfyc3kobPuzw== Received: from [10.40.0.100] (185-67-175-126.lampert.tv [185.67.175.126]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mriesch) by bali.collaboradmins.com (Postfix) with ESMTPSA id 0D2DA17E12C6; Fri, 13 Feb 2026 10:25:31 +0100 (CET) Message-ID: <1de39897-7e7b-4c49-963b-9fed48dacc81@collabora.com> Date: Fri, 13 Feb 2026 10:25:30 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] media: synopsys: use devm_reset_control_get_optional_exclusive() To: Frank Li , Mauro Carvalho Chehab , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Guoniu Zhou , Laurent Pinchart , imx@lists.linux.dev References: <20260210-imx93-dw-csi2-v1-0-69667bb86bfa@nxp.com> <20260210-imx93-dw-csi2-v1-1-69667bb86bfa@nxp.com> Content-Language: en-US From: Michael Riesch In-Reply-To: <20260210-imx93-dw-csi2-v1-1-69667bb86bfa@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Frank, Thanks for the patch series. Could you use "media: synopsys: csi2rx: " as prefix for your commit messages? On 2/10/26 18:11, Frank Li wrote: > The DW MIPI CSI-2 RX is used on different SoCs, not all of which provide a > reset controller. Switch to devm_reset_control_get_optional_exclusive() > to support such platforms. > > Reset presence and numbering are validated by the DT binding. > > Signed-off-by: Frank Li With that change, Reviewed-by: Michael Riesch Best regards, Michael > --- > drivers/media/platform/synopsys/dw-mipi-csi2rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c > index 170346ae1a599e43bba9d19476ee4d65124303bd..0cc892f4a1b3c6ce575a5d4fca7acf7057f7b7f7 100644 > --- a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c > +++ b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c > @@ -639,7 +639,7 @@ static int dw_mipi_csi2rx_probe(struct platform_device *pdev) > return dev_err_probe(dev, PTR_ERR(csi2->phy), > "failed to get MIPI CSI-2 PHY\n"); > > - csi2->reset = devm_reset_control_get_exclusive(dev, NULL); > + csi2->reset = devm_reset_control_get_optional_exclusive(dev, NULL); > if (IS_ERR(csi2->reset)) > return dev_err_probe(dev, PTR_ERR(csi2->reset), > "failed to get reset\n"); >