From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:35351 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933734AbdEVOOb (ORCPT ); Mon, 22 May 2017 10:14:31 -0400 Subject: Re: [PATCH v3 0/3] Fix mdp device tree To: Hans Verkuil , Minghsiu Tsai , Hans Verkuil , daniel.thompson@linaro.org, Rob Herring , Mauro Carvalho Chehab , Daniel Kurtz , Pawel Osciak , Houlong Wei Cc: srv_heupstream@mediatek.com, Eddie Huang , Yingjoe Chen , Wu-Cheng Li , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org References: <1494559361-42835-1-git-send-email-minghsiu.tsai@mediatek.com> <20ba4f83-7d22-2a8e-4eb6-7d4eba92e2ae@xs4all.nl> From: Matthias Brugger Message-ID: <1f7de9e7-2c18-6662-4b95-519d22a70723@gmail.com> Date: Mon, 22 May 2017 16:14:26 +0200 MIME-Version: 1.0 In-Reply-To: <20ba4f83-7d22-2a8e-4eb6-7d4eba92e2ae@xs4all.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 22/05/17 11:09, Hans Verkuil wrote: > On 05/12/2017 05:22 AM, Minghsiu Tsai wrote: > > Who should take care of the dtsi changes? I'm not sure who maintains the mdp dts. I will take care of the dtsi patches. > > The driver change and the dtsi change need to be in sync, so it is probably easiest > to merge this via one tree. > > Here is my Acked-by for these three patches: > > Acked-by: Hans Verkuil > > I can take all three, provided I have the Ack of the mdp dts maintainer. Or it can > go through him with my Ack. > I think we should provide backwards compability instead, as proposed here: http://lists.infradead.org/pipermail/linux-mediatek/2017-May/008811.html If this change is ok for you, please let Minghsiu know so that he can provide a v4. Regards, Matthias > Regards, > > Hans > >> Changes in v3: >> - Upload patches again because forget to add v2 in title >> >> Changes in v2: >> - Update commit message >> >> If the mdp_* nodes are under an mdp sub-node, their corresponding >> platform device does not automatically get its iommu assigned properly. >> >> Fix this by moving the mdp component nodes up a level such that they are >> siblings of mdp and all other SoC subsystems. This also simplifies the >> device tree. >> >> Although it fixes iommu assignment issue, it also break compatibility >> with old device tree. So, the patch in driver is needed to iterate over >> sibling mdp device nodes, not child ones, to keep driver work properly. >> >> Daniel Kurtz (2): >> arm64: dts: mt8173: Fix mdp device tree >> media: mtk-mdp: Fix mdp device tree >> >> Minghsiu Tsai (1): >> dt-bindings: mt8173: Fix mdp device tree >> >> .../devicetree/bindings/media/mediatek-mdp.txt | 12 +- >> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 126 ++++++++++----------- >> drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 2 +- >> 3 files changed, 64 insertions(+), 76 deletions(-) >> >