[PATCH v8 0/3] staging: media: atomisp: indentation cleanup per directory

[PATCH v8 0/3] staging: media: atomisp: indentation cleanup per directory

[LiangCheng Wang]

This patch series focuses on cleaning up indentation (spaces, tabs) in the
AtomISP driver under drivers/staging/media/atomisp/pci/isp/kernels/.

Following previous discussions, this version:
- Applies only indentation-related changes
- Touches a limited number of files to keep the series reviewable
- Splits patches by subdirectory to improve traceability and clarity
- Does not include any clang-format output or automated rewrites
- Leaves all non-indentation checkpatch.pl warnings or errors untouched

There is no functional logic change.

---
Changes in v8:
- Reorganized cleanup by subdirectory (one commit per directory)
- Focused only on indentation fixes (spaces, tabs)
- Removed all clang-format involvement
- No functional changes
- Link to v7: https://lore.kernel.org/all/20250629113050.58138-1-zaq14760@gmail.com/

Changes in v7:
- Split previous monolithic patch into multiple smaller patches
- Applied clang-format to entire driver excluding i2c directory
- Fixed checkpatch.pl-reported ERRORs (parentheses in macros, unnecessary return parentheses, zero-initialized globals, spaces after unary minus)
- Left WARNINGS untouched for future cleanup
- No functional logic changes
- Link to v6: https://lore.kernel.org/r/20250627-bar-v6-1-b22b5ea3ced0@gmail.com

Changes in v6:
- Applied clang-format across the entire AtomISP driver
- Fixed all checkpatch.pl-reported ERRORs
- Added explanation of tooling and scope
- No functional logic modified
- Moved 'Suggested-by' and 'Link' tags above Signed-off-by
- Link to v5: https://lore.kernel.org/r/20250625-bar-v5-1-db960608b607@gmail.com

Changes in v5:
- Replaced space-based indentation with tabs in output_1.0 directory
- Used checkpatch.pl and grep to identify formatting issues
- No functional changes made
- This patch is now focused solely on tab/space issues
- Link to v4: https://lore.kernel.org/r/20250624-bar-v4-1-9f9f9ae9f868@gmail.com

Changes in v4:
- Moved assignment operator '=' to the same line for static struct definitions
- Remove unnecessary line breaks in function definitions
- Update commit message to reflect all the coding style fixes
- Link to v3: https://lore.kernel.org/r/20250622-bar-v3-1-4cc91ef01c3a@gmail.com

Changes in v3:
- Removed extra spaces between type and asterisk (e.g., `*to`) in function
  declarations, as pointed out by Andy Shevchenko
- Update commit message to reflect all the coding style fixes
- Link to v2: https://lore.kernel.org/r/20250621-bar-v2-1-4e6cfc779614@gmail.com

Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.
- Link to v1: https://lore.kernel.org/r/20250621-bar-v1-1-5a3e7004462c@gmail.com

Thanks for your previous feedback.

Best regards,  
LiangCheng Wang <zaq14760@gmail.com>

Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>

---
LiangCheng Wang (3):
      staging: media: atomisp: fix indentation in aa
      staging: media: atomisp: fix indentation in anr
      staging: media: atomisp: fix indentation in bh

 .../pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h     |  2 +-
 .../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c  | 29 +++++++++-------------
 .../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h  | 17 ++++++-------
 .../pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h |  4 +--
 .../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c   | 12 ++++-----
 .../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h   | 11 ++++----
 .../pci/isp/kernels/bh/bh_2/ia_css_bh.host.c       | 18 ++++++--------
 .../pci/isp/kernels/bh/bh_2/ia_css_bh.host.h       | 12 ++++-----
 .../pci/isp/kernels/bh/bh_2/ia_css_bh_types.h      | 14 +++++------
 9 files changed, 52 insertions(+), 67 deletions(-)
---
base-commit: 4c06e63b92038fadb566b652ec3ec04e228931e8
change-id: 20250704-new_atomisp-e73f471f3078

Best regards,
-- 
LiangCheng Wang <zaq14760@gmail.com>

[PATCH v8 1/3] staging: media: atomisp: fix indentation in aa

[LiangCheng Wang]

This patch fixes tab/space indentation issues in aa
following kernel coding style guidelines.

No functional logic changes were made.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/all/CAHp75VcPzq9XrFD29+uZ1rbFcDxb4UbXNkv_QZ=3iyVm3dxyPg@mail.gmail.com/
Suggested-by: Hans de Goede <hansg@kernel.org>
Link: https://lore.kernel.org/all/e201c4b0-4fcc-4d98-9d76-0e9c41dc4d9f@kernel.org/
Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
---
 .../staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h b/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h
index 2f568a7062da726397f55b1e73dadd27fcd1f2f8..edca987ee20931cc124a9af74a14698ec12419e5 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h
@@ -30,7 +30,7 @@
  *     ISP2: BAA2 is used.
  */
 struct ia_css_aa_config {
-	u16 strength;	/** Strength of the filter.
+	u16 strength; /** Strength of the filter.
 					u0.13, [0,8191],
 					default/ineffective 0 */
 };

-- 
2.43.0

[PATCH v8 2/3] staging: media: atomisp: fix indentation in anr

[LiangCheng Wang]

This patch fixes tab/space indentation issues in anr
following kernel coding style guidelines.

No functional logic changes were made.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/all/CAHp75VcPzq9XrFD29+uZ1rbFcDxb4UbXNkv_QZ=3iyVm3dxyPg@mail.gmail.com/
Suggested-by: Hans de Goede <hansg@kernel.org>
Link: https://lore.kernel.org/all/e201c4b0-4fcc-4d98-9d76-0e9c41dc4d9f@kernel.org/
Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
---
 .../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c  | 29 +++++++++-------------
 .../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h  | 17 ++++++-------
 .../pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h |  4 +--
 .../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c   | 12 ++++-----
 .../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h   | 11 ++++----
 5 files changed, 31 insertions(+), 42 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
index 899d566234b9d3a35401666dcf0c7b1b80fd5b31..98e5c3c49952a3024bf7a0ee3e09c66ae88c97b7 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c
@@ -12,29 +12,25 @@
 
 const struct ia_css_anr_config default_anr_config = {
 	10,
-	{
-		0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
-		0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
-		0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
-		0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4
-	},
-	{10, 20, 30}
+	{ 0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
+	  0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
+	  0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
+	  0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4 },
+	{ 10, 20, 30 }
 };
 
 void
-ia_css_anr_encode(
-    struct sh_css_isp_anr_params *to,
-    const struct ia_css_anr_config *from,
-    unsigned int size)
+ia_css_anr_encode(struct sh_css_isp_anr_params *to,
+		  const struct ia_css_anr_config *from,
+		  unsigned int size)
 {
 	(void)size;
 	to->threshold = from->threshold;
 }
 
 void
-ia_css_anr_dump(
-    const struct sh_css_isp_anr_params *anr,
-    unsigned int level)
+ia_css_anr_dump(const struct sh_css_isp_anr_params *anr,
+		unsigned int level)
 {
 	if (!anr) return;
 	ia_css_debug_dtrace(level, "Advance Noise Reduction:\n");
@@ -43,9 +39,8 @@ ia_css_anr_dump(
 }
 
 void
-ia_css_anr_debug_dtrace(
-    const struct ia_css_anr_config *config,
-    unsigned int level)
+ia_css_anr_debug_dtrace(const struct ia_css_anr_config *config,
+			unsigned int level)
 {
 	ia_css_debug_dtrace(level,
 			    "config.threshold=%d\n",
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h
index 4f77900871c8b9d43bdc00308aa914eda3af7fa7..732ee8924df0a5352c8558521520d723be09626f 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h
@@ -13,19 +13,16 @@
 extern const struct ia_css_anr_config default_anr_config;
 
 void
-ia_css_anr_encode(
-    struct sh_css_isp_anr_params *to,
-    const struct ia_css_anr_config *from,
-    unsigned int size);
+ia_css_anr_encode(struct sh_css_isp_anr_params *to,
+		  const struct ia_css_anr_config *from,
+		  unsigned int size);
 
 void
-ia_css_anr_dump(
-    const struct sh_css_isp_anr_params *anr,
-    unsigned int level);
+ia_css_anr_dump(const struct sh_css_isp_anr_params *anr,
+		unsigned int level);
 
 void
-ia_css_anr_debug_dtrace(
-    const struct ia_css_anr_config *config, unsigned int level)
-;
+ia_css_anr_debug_dtrace(const struct ia_css_anr_config *config,
+			unsigned int level);
 
 #endif /* __IA_CSS_ANR_HOST_H */
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
index 6e573ceaa9ea2ecd7da6517c9f2ec5996f56087f..af65a47e9cca297da945b0b77add9226b20e1b27 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
@@ -12,8 +12,8 @@
  */
 
 /* Application specific DMA settings  */
-#define ANR_BPP                 10
-#define ANR_ELEMENT_BITS        ((CEIL_DIV(ANR_BPP, 8)) * 8)
+#define ANR_BPP 10
+#define ANR_ELEMENT_BITS ((CEIL_DIV(ANR_BPP, 8)) * 8)
 
 /* Advanced Noise Reduction configuration.
  *  This is also known as Low-Light.
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c
index 09599884bdaefe32f891f437274b96110888a675..a7c0285bc63498fcb2e51f09fe1ed4a12ed4f3d0 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c
@@ -11,10 +11,9 @@
 #include "ia_css_anr2.host.h"
 
 void
-ia_css_anr2_vmem_encode(
-    struct ia_css_isp_anr2_params *to,
-    const struct ia_css_anr_thres *from,
-    size_t size)
+ia_css_anr2_vmem_encode(struct ia_css_isp_anr2_params *to,
+			const struct ia_css_anr_thres *from,
+			size_t size)
 {
 	unsigned int i;
 
@@ -29,9 +28,8 @@ ia_css_anr2_vmem_encode(
 }
 
 void
-ia_css_anr2_debug_dtrace(
-    const struct ia_css_anr_thres *config,
-    unsigned int level)
+ia_css_anr2_debug_dtrace(const struct ia_css_anr_thres *config,
+			 unsigned int level)
 {
 	(void)config;
 	(void)level;
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h
index 2b1105f21c1e2b37144083b6bb8f9dd465a2f43b..f57acff112ee17670114658b1c4b7ce9203362ca 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h
@@ -14,14 +14,13 @@
 #include "ia_css_anr2_table.host.h"
 
 void
-ia_css_anr2_vmem_encode(
-    struct ia_css_isp_anr2_params *to,
-    const struct ia_css_anr_thres *from,
-    size_t size);
+ia_css_anr2_vmem_encode(struct ia_css_isp_anr2_params *to,
+			const struct ia_css_anr_thres *from,
+			size_t size);
 
 void
-ia_css_anr2_debug_dtrace(
-    const struct ia_css_anr_thres *config, unsigned int level)
+ia_css_anr2_debug_dtrace(const struct ia_css_anr_thres *config,
+			 unsigned int level)
 ;
 
 #endif /* __IA_CSS_ANR2_HOST_H */

-- 
2.43.0

[PATCH v8 3/3] staging: media: atomisp: fix indentation in bh

[LiangCheng Wang]

This patch fixes tab/space indentation issues in bh
following kernel coding style guidelines.

No functional logic changes were made.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/all/CAHp75VcPzq9XrFD29+uZ1rbFcDxb4UbXNkv_QZ=3iyVm3dxyPg@mail.gmail.com/
Suggested-by: Hans de Goede <hansg@kernel.org>
Link: https://lore.kernel.org/all/e201c4b0-4fcc-4d98-9d76-0e9c41dc4d9f@kernel.org/
Signed-off-by: LiangCheng Wang<zaq14760@gmail.com>
---
 .../atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c   | 18 ++++++++----------
 .../atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h   | 12 +++++-------
 .../atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh_types.h  | 14 +++++++-------
 3 files changed, 20 insertions(+), 24 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c
index 69c87e53f3c22fade6c4c7914d1550f68dd8f5c2..c120ecb178b2c60a3512725327779819d1888268 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.c
@@ -13,9 +13,8 @@
 #include "ia_css_bh.host.h"
 
 void
-ia_css_bh_hmem_decode(
-    struct ia_css_3a_rgby_output *out_ptr,
-    const struct ia_css_bh_table *hmem_buf)
+ia_css_bh_hmem_decode(struct ia_css_3a_rgby_output *out_ptr,
+		      const struct ia_css_bh_table *hmem_buf)
 {
 	int i;
 
@@ -38,18 +37,17 @@ ia_css_bh_hmem_decode(
 }
 
 void
-ia_css_bh_encode(
-    struct sh_css_isp_bh_params *to,
-    const struct ia_css_3a_config *from,
-    unsigned int size)
+ia_css_bh_encode(struct sh_css_isp_bh_params *to,
+		 const struct ia_css_3a_config *from,
+		 unsigned int size)
 {
 	(void)size;
 	/* coefficients to calculate Y */
 	to->y_coef_r =
-	    uDIGIT_FITTING(from->ae_y_coef_r, 16, SH_CSS_AE_YCOEF_SHIFT);
+		uDIGIT_FITTING(from->ae_y_coef_r, 16, SH_CSS_AE_YCOEF_SHIFT);
 	to->y_coef_g =
-	    uDIGIT_FITTING(from->ae_y_coef_g, 16, SH_CSS_AE_YCOEF_SHIFT);
+		uDIGIT_FITTING(from->ae_y_coef_g, 16, SH_CSS_AE_YCOEF_SHIFT);
 	to->y_coef_b =
-	    uDIGIT_FITTING(from->ae_y_coef_b, 16, SH_CSS_AE_YCOEF_SHIFT);
+		uDIGIT_FITTING(from->ae_y_coef_b, 16, SH_CSS_AE_YCOEF_SHIFT);
 }
 
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h
index 36b360cfe62e65037522e0037cf51fca0fabdfba..9912dfea06074c6ecdbb1afb8de771b54b45aebf 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh.host.h
@@ -11,14 +11,12 @@
 #include "s3a/s3a_1.0/ia_css_s3a_types.h"
 
 void
-ia_css_bh_hmem_decode(
-    struct ia_css_3a_rgby_output *out_ptr,
-    const struct ia_css_bh_table *hmem_buf);
+ia_css_bh_hmem_decode(struct ia_css_3a_rgby_output *out_ptr,
+		      const struct ia_css_bh_table *hmem_buf);
 
 void
-ia_css_bh_encode(
-    struct sh_css_isp_bh_params *to,
-    const struct ia_css_3a_config *from,
-    unsigned int size);
+ia_css_bh_encode(struct sh_css_isp_bh_params *to,
+		 const struct ia_css_3a_config *from,
+		 unsigned int size);
 
 #endif /* __IA_CSS_BH_HOST_H */
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh_types.h b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh_types.h
index c717c636f666b984665f9d11c494843b55ee8c92..d62cb05d201dc8c9cabda03256f1d16103c5161a 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh_types.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/bh/bh_2/ia_css_bh_types.h
@@ -10,14 +10,14 @@
 /* Number of elements in the BH table.
   * Should be consistent with hmem.h
   */
-#define IA_CSS_HMEM_BH_TABLE_SIZE	ISP_HIST_DEPTH
-#define IA_CSS_HMEM_BH_UNIT_SIZE	(ISP_HIST_DEPTH / ISP_HIST_COMPONENTS)
+#define IA_CSS_HMEM_BH_TABLE_SIZE ISP_HIST_DEPTH
+#define IA_CSS_HMEM_BH_UNIT_SIZE (ISP_HIST_DEPTH / ISP_HIST_COMPONENTS)
 
-#define BH_COLOR_R	(0)
-#define BH_COLOR_G	(1)
-#define BH_COLOR_B	(2)
-#define BH_COLOR_Y	(3)
-#define BH_COLOR_NUM	(4)
+#define BH_COLOR_R (0)
+#define BH_COLOR_G (1)
+#define BH_COLOR_B (2)
+#define BH_COLOR_Y (3)
+#define BH_COLOR_NUM (4)
 
 /* BH table */
 struct ia_css_bh_table {

-- 
2.43.0

Re: [PATCH v8 2/3] staging: media: atomisp: fix indentation in anr

[Andy Shevchenko]

On Fri, Jul 4, 2025 at 6:41 PM LiangCheng Wang <zaq14760@gmail.com> wrote:
>
> This patch fixes tab/space indentation issues in anr
> following kernel coding style guidelines.
>
> No functional logic changes were made.

...

> -       {
> -               0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> -               0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> -               0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> -               0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4
> -       },
> +       { 0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> +         0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> +         0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4,
> +         0, 3, 1, 2, 3, 6, 4, 5, 1, 4, 2, 3, 2, 5, 3, 4 },

This change is not okay. Please, leave the curly braces on their own lines.

> -       {10, 20, 30}
> +       { 10, 20, 30 }

This is okay, but also makes sense to add a trailing comma.

...

>  void
> -ia_css_anr_encode(
> -    struct sh_css_isp_anr_params *to,
> -    const struct ia_css_anr_config *from,
> -    unsigned int size);
> +ia_css_anr_encode(struct sh_css_isp_anr_params *to,
> +                 const struct ia_css_anr_config *from,
> +                 unsigned int size);

Don't we want to have something like

void ia_css_anr_encode(struct sh_css_isp_anr_params *to,
                      const struct ia_css_anr_config *from,
                      unsigned int size);

?

Ditto for other similar cases.

...

>  /* Application specific DMA settings  */
> -#define ANR_BPP                 10
> -#define ANR_ELEMENT_BITS        ((CEIL_DIV(ANR_BPP, 8)) * 8)
> +#define ANR_BPP 10
> +#define ANR_ELEMENT_BITS ((CEIL_DIV(ANR_BPP, 8)) * 8)

Doesn't look like a good change.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v8 1/3] staging: media: atomisp: fix indentation in aa

[Andy Shevchenko]

On Fri, Jul 4, 2025 at 6:41 PM LiangCheng Wang <zaq14760@gmail.com> wrote:
>
> This patch fixes tab/space indentation issues in aa
> following kernel coding style guidelines.
>
> No functional logic changes were made.

...

>   *     ISP2: BAA2 is used.
>   */
>  struct ia_css_aa_config {
> -       u16 strength;   /** Strength of the filter.
> +       u16 strength; /** Strength of the filter.
>                                         u0.13, [0,8191],
>                                         default/ineffective 0 */
>  };

This seems to be a kernel-doc format. Instead of fixing this, move the
description of the field to the top comment and make sure it follows
kernel-doc. In such case the change will be much more useful.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v8 3/3] staging: media: atomisp: fix indentation in bh

[Andy Shevchenko]

On Fri, Jul 4, 2025 at 6:41 PM LiangCheng Wang <zaq14760@gmail.com> wrote:
>
> This patch fixes tab/space indentation issues in bh
> following kernel coding style guidelines.
>
> No functional logic changes were made.

...

>  void
> -ia_css_bh_hmem_decode(
> -    struct ia_css_3a_rgby_output *out_ptr,
> -    const struct ia_css_bh_table *hmem_buf)
> +ia_css_bh_hmem_decode(struct ia_css_3a_rgby_output *out_ptr,
> +                     const struct ia_css_bh_table *hmem_buf)

Same comment as per previous patch.

...

>         to->y_coef_r =
> -           uDIGIT_FITTING(from->ae_y_coef_r, 16, SH_CSS_AE_YCOEF_SHIFT);
> +               uDIGIT_FITTING(from->ae_y_coef_r, 16, SH_CSS_AE_YCOEF_SHIFT);
>         to->y_coef_g =
> -           uDIGIT_FITTING(from->ae_y_coef_g, 16, SH_CSS_AE_YCOEF_SHIFT);
> +               uDIGIT_FITTING(from->ae_y_coef_g, 16, SH_CSS_AE_YCOEF_SHIFT);
>         to->y_coef_b =
> -           uDIGIT_FITTING(from->ae_y_coef_b, 16, SH_CSS_AE_YCOEF_SHIFT);
> +               uDIGIT_FITTING(from->ae_y_coef_b, 16, SH_CSS_AE_YCOEF_SHIFT);

Not sure what's going on here. But I think this is just a churn.

...

> -#define IA_CSS_HMEM_BH_TABLE_SIZE      ISP_HIST_DEPTH
> -#define IA_CSS_HMEM_BH_UNIT_SIZE       (ISP_HIST_DEPTH / ISP_HIST_COMPONENTS)
> +#define IA_CSS_HMEM_BH_TABLE_SIZE ISP_HIST_DEPTH
> +#define IA_CSS_HMEM_BH_UNIT_SIZE (ISP_HIST_DEPTH / ISP_HIST_COMPONENTS)
>
> -#define BH_COLOR_R     (0)
> -#define BH_COLOR_G     (1)
> -#define BH_COLOR_B     (2)
> -#define BH_COLOR_Y     (3)
> -#define BH_COLOR_NUM   (4)
> +#define BH_COLOR_R (0)
> +#define BH_COLOR_G (1)
> +#define BH_COLOR_B (2)
> +#define BH_COLOR_Y (3)
> +#define BH_COLOR_NUM (4)

Doesn't look like a good change.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v8 1/3] staging: media: atomisp: fix indentation in aa

[Dan Carpenter]

In the subject "aa" is weird and confusing.  Say "ia_css_aa_config"
instead.

regards,
dan carpenter