public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Brandon Philips <brandon@ifup.org>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>,
	video4linux-list@redhat.com, Michael Krufky <mkrufky@linuxtv.org>,
	v4lm <v4l-dvb-maintainer@linuxtv.org>
Subject: Re: NACK NACK!  [PATCH] Add two new fourcc codes for 16bpp formats
Date: Tue, 5 Feb 2008 15:15:06 -0800	[thread overview]
Message-ID: <20080205231506.GD10319@plankton.ifup.org> (raw)
In-Reply-To: <20080205120102.76ccd526@gaivota>

On 12:01 Tue 05 Feb 2008, Mauro Carvalho Chehab wrote:
> On Tue, 05 Feb 2008 08:23:28 -0500
> Michael Krufky <mkrufky@linuxtv.org> wrote:
> 
> > Brandon Philips wrote:
> > > - mailimport changes in this commit too!  Why is mailimport running
> > >   sudo!?! 
> > 
> > I understand that unrelated changes were accidentally merged with a single commit, but why would we want this script to call sudo in the first place?
> > 
> > I think it's bad practice, for such a script to execute commands as root -- 
> > 
> > Can you explain, Mauro?
> 
> The script itself doesn't open any new vulnerabilities. Sudo only works if 
> configured at /etc/sudoers.

I don't use the script but I would certainly remove the sudo calls in my
local version if I started to.  A patch tool really shouldn't need sudo.
If the perms are wrong the user can write a wrapper script to fix them.

> 2) the user of the second account types his password (or, otherwise, sudo is
> configured to not ask for passwords - on very weak environments).

sudo defaults to a 15 grace period where it doesn't ask for a password
again.

	Brandon

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2008-02-05 23:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05  1:24 NACK NACK! [PATCH] Add two new fourcc codes for 16bpp formats Brandon Philips
2008-02-05  7:16 ` Guennadi Liakhovetski
2008-02-05  8:00   ` Brandon Philips
2008-02-05 12:24     ` Mauro Carvalho Chehab
     [not found]       ` <20080213202055.GA26352@plankton.ifup.org>
2008-02-13 23:24         ` [v4l-dvb-maintainer] Moving to git for v4l-dvb Michael Krufky
2008-02-13 23:54           ` Alex Deucher
2008-02-14  0:56             ` Michael Krufky
2008-02-13 23:55           ` hermann pitton
2008-02-14  2:34           ` Brandon Philips
2008-02-14  2:35             ` Michael Krufky
2008-02-14 12:20               ` Mauro Carvalho Chehab
2008-02-14 19:46         ` Mauro Carvalho Chehab
2008-02-14 23:08           ` Brandon Philips
2008-12-17 14:12           ` Guennadi Liakhovetski
2008-12-17 14:18             ` Michael Krufky
2008-12-17 14:33               ` Guennadi Liakhovetski
2008-12-17 16:52                 ` Mauro Carvalho Chehab
2008-12-17 17:05                   ` Guennadi Liakhovetski
2008-12-17 18:23                     ` Mauro Carvalho Chehab
2008-02-05 13:23 ` NACK NACK! [PATCH] Add two new fourcc codes for 16bpp formats Michael Krufky
2008-02-05 14:01   ` Mauro Carvalho Chehab
2008-02-05 23:15     ` Brandon Philips [this message]
2008-02-06  1:27       ` Michael Krufky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080205231506.GD10319@plankton.ifup.org \
    --to=brandon@ifup.org \
    --cc=g.liakhovetski@pengutronix.de \
    --cc=mchehab@infradead.org \
    --cc=mkrufky@linuxtv.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox