From: Oliver Endriss <o.endriss@gmx.de>
To: Christoph Pfister <christophpfister@gmail.com>
Cc: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] CI/CAM fixes for knc1 dvb-s cards
Date: Fri, 4 Apr 2008 01:33:05 +0200 [thread overview]
Message-ID: <200804040133.05892@orion.escape-edv.de> (raw)
In-Reply-To: <200803281820.54243.christophpfister@gmail.com>
Christoph Pfister wrote:
> > > <<<fix-knc1-dvbs-ci.diff>>>
> > > case SUBID_DVBS_KNC1:
> > > case SUBID_DVBS_KNC1_PLUS:
> > > case SUBID_DVBS_EASYWATCH_1:
> > >+ budget_av->reinitialise_demod = 1;
> > >
> > > Fix CI interface on (some) KNC1 DVBS cards
> > > Quoting the commit introducing reinitialise_demod (3984 / by adq):
> > > "These cards [KNC1 DVBT and DVBC] need special handling for CI -
> > > reinitialising the frontend device when the CI module is reset."
> > > Apparently my 1894:0010 also needs that fix, because once you initialise
> > > CI/CAM you lose lock. Signed-off-by: Christoph Pfister
> > > <pfister@linuxtv.org>
> >
> > Are you _sure_ that 'reinitialise_demod = 1' is required by all 3 card
> > types, and does not hurt for SUBID_DVBS_KNC1_PLUS (1131:0011, 1894:0011)
> > and SUBID_DVBS_EASYWATCH_1 (1894:001a)?
>
> Do you want me to limit reinitialise_demod to the one type of card I'm using
> or is it ok for you this way?
Yes, please. We should not add a quirk unless we have verified that it
is really required. It is easier to add a hack than to remove it. ;-)
> (I'll repost a modified version of the first patch removing the 0xff check
> altogether later today ...)
OK. I'll commit your patches this weekend.
--
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
----------------------------------------------------------------
_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
next prev parent reply other threads:[~2008-04-04 0:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 19:24 [linux-dvb] CI/CAM fixes for knc1 dvb-s cards Christoph Pfister
2008-03-22 6:32 ` Oliver Endriss
2008-03-22 12:56 ` Christoph Pfister
2008-03-28 17:20 ` Christoph Pfister
2008-03-28 21:57 ` Christoph Pfister
2008-04-03 23:33 ` Oliver Endriss [this message]
2008-04-05 13:14 ` Christoph Pfister
2008-04-11 22:01 ` Oliver Endriss
2008-03-22 11:31 ` e9hack
2008-03-22 13:13 ` Christoph Pfister
2008-03-22 15:46 ` thomas schorpp
2008-03-28 10:45 ` Arthur Konovalov
2008-03-28 14:35 ` Christoph Pfister
2008-03-28 15:06 ` Arthur Konovalov
2008-03-28 17:16 ` Christoph Pfister
2008-03-28 20:22 ` Arthur Konovalov
2008-03-28 22:02 ` Christoph Pfister
2008-03-28 23:59 ` Arthur Konovalov
2008-03-29 15:00 ` Christoph Pfister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804040133.05892@orion.escape-edv.de \
--to=o.endriss@gmx.de \
--cc=christophpfister@gmail.com \
--cc=linux-dvb@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox