Re: [linux-dvb] [PATCH] Add driver specific module option to choose dvb adapter numbers, second try

From: Oliver Endriss <o.endriss@gmx.de>
To: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] [PATCH] Add driver specific module option to choose dvb adapter numbers, second try
Date: Wed, 9 Apr 2008 18:50:53 +0200	[thread overview]
Message-ID: <200804091850.54005@orion.escape-edv.de> (raw)
In-Reply-To: <37219a840804090745q1f3cc495s7ce63d59793cac4a@mail.gmail.com>

Michael Krufky wrote:
> (sorry for the double-email -- accidentally sent from the wrong email account)
> 
> On Wed, Apr 9, 2008 at 5:21 AM, Janne Grunau <janne-dvb@grunau.be> wrote:
> > On Wednesday 09 April 2008 00:22:40 Oliver Endriss wrote:
> >
> > > Michael Krufky wrote:
> >  > >
> >  > > I would really like to see this patch get merged.
> >  > >
> >  > > If nobody has an issue with this, I plan to push this into a
> >  > > mercurial tree at the end of the week and request that it be merged
> >  > > into the master branch.
> >  >
> >  > Correct me if I'm wrong, but afaik the option should be named
> >  > 'adapter_no', not 'adapter_nr'.
> >
> >  The usual english abbreviation for number is no. OTOH the respective V4L
> >  options are also called video|radio|vbi _nr, so calling it adapter_nr
> >  would be consistent with V4L.
> >
> >  I'm not sure which argument is more important but it won't be much work
> >  to change it o adapter_no.
> >
> >  Janne
> 
> I believe that the "nr" abbreviation comes from the German language.
> (correct me if I'm wrong)

Yep.

> Perhaps the abbreviation, "no" is more correct, since it is based on
> the English language, but to me this is of no significance, since v4l
> uses the "nr" abbreviation and this is globally understood.
> 
> If Oliver perfers "adapter_no" then lets go with it.  Otherwise, it's
> fine as-is.

Basically _I_ don't care at all, but obviously there are some guys who
search the code for typos. I guess they will find this one sooner or
later, and we have to change it anyway.

But if you'd like to use nr it is ok for me.

CU
Oliver

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
----------------------------------------------------------------

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb