From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Michael Krufky <mkrufky@linuxtv.org>
Cc: video4linux-list@redhat.com, linux-kernel@vger.kernel.org,
ivtv-devel@ivtvdriver.org, Frank Bennett <biercenator@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] Fix VIDIOCGAP corruption in ivtv
Date: Wed, 23 Apr 2008 14:34:54 -0300 [thread overview]
Message-ID: <20080423143454.0d50b209@gaivota> (raw)
In-Reply-To: <480B6AD8.9090404@linuxtv.org>
On Sun, 20 Apr 2008 12:10:00 -0400
Michael Krufky <mkrufky@linuxtv.org> wrote:
> Hans Verkuil wrote:
> > On Sunday 20 April 2008 13:27:36 Alan Cox wrote:
> >
> >> Frank Bennett reported that ivtv was causing skype to crash. With
> >> help from one of their developers he showed it was a kernel problem.
> >> VIDIOCGCAP copies a name into a fixed length buffer - ivtv uses names
> >> that are too long and does not truncate them so corrupts a few bytes
> >> of the app data area.
> >>
> >> Possibly the names also want trimming but for now this should fix the
> >> corruption case.
> >>
> >
> > Ouch, nasty one.
> >
> > Mauro, can you apply this patch to the v4l-dvb master?
> >
> > Mike, this one should obviously go into a 2.6.25 dot-release, and I
> > think also to a 2.6.24 dot-release.
> >
> > Frank, thank you for reporting this!
> >
> > Hans
> >
> > Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
> >
>
> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
In this case, it should be reviewed-by.
I should be sending this soon to Linus.
Cheers,
Mauro
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-04-23 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-20 11:27 [PATCH] Fix VIDIOCGAP corruption in ivtv Alan Cox
2008-04-20 16:06 ` Hans Verkuil
2008-04-20 16:10 ` Michael Krufky
2008-04-23 17:34 ` Mauro Carvalho Chehab [this message]
2008-04-23 18:03 ` mkrufky
2008-04-24 2:24 ` Mauro Carvalho Chehab
2008-04-24 3:03 ` Michael Krufky
[not found] ` <53208a5f0804231226n3cf04ea5ja3cebb5584886183@mail.gmail.com>
2008-04-24 15:47 ` Mauro Carvalho Chehab
2008-04-24 16:00 ` Alan Cox
2008-04-24 16:19 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080423143454.0d50b209@gaivota \
--to=mchehab@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=biercenator@gmail.com \
--cc=ivtv-devel@ivtvdriver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox