[BUG] sound is unmuted by default with 2.6.26-rc1 on my FlyVideo 2000

From: Maxim Levitsky <maximlevitsky@gmail.com>
To: "Video-4l-list" <video4linux-list@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [BUG] sound is unmuted by default with 2.6.26-rc1 on my FlyVideo 2000
Date: Wed, 7 May 2008 14:36:03 +0300	[thread overview]
Message-ID: <200805071436.03569.maximlevitsky@gmail.com> (raw)

Hi,

I was very busy, thus I didn't follow kernel development lately.
I skipped whole 2.6.25 cycle.

Now I have a bit more free time, so I updated kernel to 2.6.25, and then
to latest -git.

In latest git I noticed that sound output of my TV card is unmuted by default.

commit 7bff4b4d3ad2b9ff42b4087f409076035af1d165, clears all GPIO lines,
and on my card mute is implemented with external chip which is connected via GPIO,
and this results in the above bug.

The code that clears all gpios executed last, thus it undoes the saa7134_tvaudio_setmute
in saa7134_video_init2.

moving saa7134_tvaudio_setmute after gpio clearing doesn't help, bacause this function is
"smart" thus it remembers last mute state and touches the hardware only if this state changes.
(And first time it is called from video_mux, thus explict call from saa7134_video_init2 isn't necessary I think)

I once had trouble with this thing, when wrote the resume code, thus I added a flag (dev->insuspend
that made this function set mute state always when set.
(This is a bit hackish, but I had to use this flag anyway in other places, so I decided that this is ok)

I could remove this "smart" check, but I tested and found that this function is called qute often from tvaudio thread, and thus this check probably is correct.

Best regards,
	Maxim Levitsky

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list