Re: [patch] vivi: registered as /dev/video%d

[Mauro Carvalho Chehab <mchehab@infradead.org>]

On Wed, 28 May 2008 15:15:35 -0500
Carl Karsten <carl@personnelware.com> wrote:

> I posted a week ago and haven't heard anything.

I was on vacations last week.

>  How long should I wait before 
> posting this? :)

There are a few issues on your patch:

> -		else
> +            printk(KERN_INFO "%s: /dev/video%d unregistered.\n", MODULE_NAME,
> dev->vfd->minor);

Your patch got word wrapped. So, it didn't apply.

> +        }
> +		else {

CodingStyle is wrong. It should be:
	} else {

(at the same line)

Also, on some places, you used space, instead of tabs.

Please, check your patch with checkpatch.pl (or, inside Mercurial, make
checkpatch) before sending it.

Also, be sure that your emailer won't add line breaks at the wrong places.
>   	} else
>   		printk(KERN_INFO "Video Technology Magazine Virtual Video "
> -				 "Capture Board successfully loaded.\n");
> +                 "Capture Board ver %u.%u.%u successfully loaded.\n",
> +        (VIVI_VERSION >> 16) & 0xFF, (VIVI_VERSION >> 8) & 0xFF, VIVI_VERSION &
> 0xFF);

The indentation is very weird here.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list