From: Alan Cox <alan@redhat.com>
To: Discussion list for development of the IVTV driver
<ivtv-devel@ivtvdriver.org>
Cc: video4linux-list@redhat.com
Subject: Re: [ivtv-devel] [PATCH] cx18: convert driver to video_ioctl2() (Re: [PATCH] video4linux: Push down the BKL)
Date: Tue, 3 Jun 2008 18:08:28 -0400 [thread overview]
Message-ID: <20080603220828.GE30842@devserv.devel.redhat.com> (raw)
In-Reply-To: <20080603182052.1080408e@gaivota>
On Tue, Jun 03, 2008 at 06:20:52PM -0300, Mauro Carvalho Chehab wrote:
> > Yeah, they can go. I left them in as an aid for double checking that I
> > didn't forget any callbacks that needed to be implemented.
>
> Please don't do that. All static vars that have a value 0 or NULL shouldn't be
> initialized, since this will eat some space inside the module.
The compiler is smarter than that. Besides which 4 bytes will make no difference
whether it is data or bss given 4K disk block sizes 8)
It is coding style not to do it but it isn't a bad idea to leave them in if
they make something explicitly clear IMHO.
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-06-03 22:08 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 21:37 [PATCH] video4linux: Push down the BKL Alan Cox
2008-05-23 2:08 ` Andy Walls
2008-05-23 6:16 ` Hans Verkuil
2008-05-23 6:28 ` Hans Verkuil
2008-05-26 16:39 ` Mauro Carvalho Chehab
2008-05-23 9:09 ` Alan Cox
2008-05-26 16:34 ` Mauro Carvalho Chehab
2008-05-26 16:46 ` Hans Verkuil
2008-05-26 21:14 ` Mauro Carvalho Chehab
2008-06-01 2:34 ` [PATCH] cx18: convert driver to video_ioctl2() (Re: [PATCH] video4linux: Push down the BKL) Andy Walls
2008-06-01 10:15 ` Hans Verkuil
2008-06-01 19:01 ` Andy Walls
2008-06-03 21:20 ` Mauro Carvalho Chehab
2008-06-03 22:08 ` Alan Cox [this message]
2008-06-04 0:44 ` [ivtv-devel] " Andy Walls
2008-06-04 10:02 ` Alan Cox
[not found] ` <9027.1211551014@vena.lwn.net>
2008-05-23 15:39 ` [PATCH] video4linux: Push down the BKL Alan Cox
[not found] ` <15168.1211558968@vena.lwn.net>
2008-05-23 18:58 ` Alan Cox
2008-05-23 19:05 ` Hans Verkuil
2008-05-25 23:46 ` Mike Isely
2008-05-26 16:59 ` Mauro Carvalho Chehab
2008-05-26 20:23 ` Alan Cox
2008-05-26 21:10 ` Mauro Carvalho Chehab
2008-05-26 22:01 ` Alan Cox
2008-05-27 13:10 ` Mauro Carvalho Chehab
[not found] ` <20080527094144.1189826a@bike.lwn.net>
2008-05-27 16:31 ` Mauro Carvalho Chehab
2008-05-27 18:14 ` Alan Cox
[not found] ` <20080527103755.1fd67ec1@bike.lwn.net>
2008-05-27 18:59 ` Mauro Carvalho Chehab
2008-05-27 19:26 ` Devin Heitmueller
2008-05-27 21:00 ` Mauro Carvalho Chehab
2008-05-27 21:22 ` Devin Heitmueller
2008-05-27 23:48 ` Andy Walls
2008-05-28 0:46 ` Devin Heitmueller
2008-05-28 2:37 ` Andy Walls
2008-05-28 2:47 ` Devin Heitmueller
2008-05-28 23:30 ` Andy Walls
2008-05-28 8:34 ` Alan Cox
2008-05-28 6:13 ` Hans Verkuil
[not found] ` <20080527125041.0fc28fd4@infradead.org>
2008-05-27 20:24 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603220828.GE30842@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=ivtv-devel@ivtvdriver.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox