From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: timf <timf@iinet.net.au>
Cc: video4linux-list@redhat.com, linux-dvb@linuxtv.org
Subject: Re: [PATCH] Avermedia A16d Avermedia E506
Date: Sun, 15 Jun 2008 08:34:47 -0300 [thread overview]
Message-ID: <20080615083447.4d288a9e@gaivota> (raw)
In-Reply-To: <48513259.6030003@iinet.net.au>
On Thu, 12 Jun 2008 22:27:37 +0800
timf <timf@iinet.net.au> wrote:
>
> Hi Mauro,
>
> OK, Herewith find the patch for the Avermedia A16d, and the Avermedia
> E506 Cardbus.
> I am using Thunderbird, so as well as pasting it here I shall attach it.
> DVB-T, Analog-TV, FM-Radio - work for both cards.
> Composite, S-Video not tested.
>
> Regards,
> Timf
>
> Signed-off-by: Tim Farrington <timf@iinet.net.au>
>
Hi Tim,
Your patch didn't apply:
$ patch -p1 -i /home/v4l/tmp/mailimport23503/patch.diff
patching file linux/drivers/media/common/ir-keymaps.c
Hunk #1 succeeded at 2251 with fuzz 1.
missing header for unified diff at line 898 of patch
patching file linux/drivers/media/video/saa7134/saa7134-cards.c
Hunk #1 FAILED at 4232.
Hunk #2 FAILED at 4259.
Hunk #3 FAILED at 4272.
Hunk #4 FAILED at 5503.
Hunk #5 FAILED at 5727.
Hunk #6 FAILED at 5739.
Hunk #7 FAILED at 5865.
7 out of 7 hunks FAILED -- saving rejects to file linux/drivers/media/video/saa7134/saa7134-cards.c.rej
patching file linux/drivers/media/video/saa7134/saa7134-dvb.c
Hunk #1 FAILED at 153.
Hunk #2 FAILED at 212.
patch: **** malformed patch at line 1073: &avermedia_xc3028_mt352_dev,
Also, running checkpatch.pl generates lots of codingstyle errors and warnings.
Please, re-generate it against the latest tree, fix coding style and be sure
that your emailer is not breaking long lines or replacing tabs with spaces. If
you're using thunderbird, maybe it would be better to send, instead, as an
attachment.
Cheers,
Mauro
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-06-15 11:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 14:27 [PATCH] Avermedia A16d Avermedia E506 timf
2008-06-13 11:23 ` [linux-dvb] " luc legrand
2008-06-15 11:34 ` Mauro Carvalho Chehab [this message]
2008-06-15 12:00 ` timf
2008-06-15 12:17 ` timf
2008-06-15 12:29 ` Mauro Carvalho Chehab
2008-06-15 13:23 ` timf
2008-06-15 13:37 ` Mauro Carvalho Chehab
2008-06-15 13:57 ` timf
2008-06-16 23:12 ` Dan Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080615083447.4d288a9e@gaivota \
--to=mchehab@infradead.org \
--cc=linux-dvb@linuxtv.org \
--cc=timf@iinet.net.au \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox