[PATCH] xc5000.c xc_write_reg() wait time

[PATCH] xc5000.c xc_write_reg() wait time

[Chaogui Zhang]

This patch fixes the incorrect wait time in xc_write_reg(). Before the
patch, my Pinnacle PCTV HD 800i cannot tune to any QAM channels. After
the patch, it found all the channels without problems.

This was previously submitted back in January, as part of a much
bigger patch involving other stuff. The other parts involve hybrid tuner 
instance handling, and some code clean up. The tuner instance handling
part is obsolete now since Mike Krufky's tuner refactoring code does
precisely that and in a more efficient way, even though the xc5000 tuner
code has not been modified to take advantage of that yet.

Just for reference, the previous patch in the following thread:

http://www.linuxtv.org/pipermail/linux-dvb/2008-January/023392.html

--

Signed-off-by: Chaogui Zhang <czhang1974@gmail.com>

diff -r 55e8c99c8aa8 linux/drivers/media/common/tuners/xc5000.c
--- a/linux/drivers/media/common/tuners/xc5000.c	Wed Jul 30 07:18:13 2008 -0300
+++ b/linux/drivers/media/common/tuners/xc5000.c	Thu Jul 31 17:43:31 2008 -0400
@@ -250,7 +250,7 @@
 						/* busy flag cleared */
 					break;
 					} else {
-						xc_wait(100); /* wait 5 ms */
+						xc_wait(5); /* wait 5 ms */
 						WatchDogTimer--;
 					}
 				}

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Wanted 800i QAM tested - please reivew... Was: Re: [PATCH] xc5000.c xc_write_reg() wait time

[Steven Toth]

Chaogui Zhang wrote:
> This patch fixes the incorrect wait time in xc_write_reg(). Before the
> patch, my Pinnacle PCTV HD 800i cannot tune to any QAM channels. After
> the patch, it found all the channels without problems.
> 
> This was previously submitted back in January, as part of a much
> bigger patch involving other stuff. The other parts involve hybrid tuner 
> instance handling, and some code clean up. The tuner instance handling
> part is obsolete now since Mike Krufky's tuner refactoring code does
> precisely that and in a more efficient way, even though the xc5000 tuner
> code has not been modified to take advantage of that yet.
> 
> Just for reference, the previous patch in the following thread:
> 
> http://www.linuxtv.org/pipermail/linux-dvb/2008-January/023392.html
> 
> --
> 
> Signed-off-by: Chaogui Zhang <czhang1974@gmail.com>
> 
> diff -r 55e8c99c8aa8 linux/drivers/media/common/tuners/xc5000.c
> --- a/linux/drivers/media/common/tuners/xc5000.c	Wed Jul 30 07:18:13 2008 -0300
> +++ b/linux/drivers/media/common/tuners/xc5000.c	Thu Jul 31 17:43:31 2008 -0400
> @@ -250,7 +250,7 @@
>  						/* busy flag cleared */
>  					break;
>  					} else {
> -						xc_wait(100); /* wait 5 ms */
> +						xc_wait(5); /* wait 5 ms */
>  						WatchDogTimer--;
>  					}
>  				}

During development, using a remote users dev system the 100 value works 
reliably on his 800i for QAM, it also works very reliably on my QAM / 
ATSC systems. I'm not ware of any QAM issues across multiple vendors 
products with the 100 value.

I'm pretty skeptical about this creating QAM issues.

Does anyone else here have an 800i with QAM issues? (I'm changing the 
subject thread to attract other users).

- Steve

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [linux-dvb] Wanted 800i QAM tested - please reivew... Was: Re: [PATCH] xc5000.c xc_write_reg() wait time

[Andreas]

Am Donnerstag, 31. Juli 2008 18:38:19 schrieb Steven Toth:
> Does anyone else here have an 800i with QAM issues? (I'm changing the
> subject thread to attract other users).
>

No issues here. I just did a scan and it found 368 services (QAM 256).
That is on a AMD x2 x86_64, Kernel 2.6.22.17 with dvb drivers from mercurial 
about one week old.

-- 
Gruß
Andreas

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] Wanted 800i QAM tested - please reivew... Was: Re: [PATCH] xc5000.c xc_write_reg() wait time

[Steven Toth]

Andreas wrote:
> Am Donnerstag, 31. Juli 2008 18:38:19 schrieb Steven Toth:
>> Does anyone else here have an 800i with QAM issues? (I'm changing the
>> subject thread to attract other users).
>>
> 
> No issues here. I just did a scan and it found 368 services (QAM 256).
> That is on a AMD x2 x86_64, Kernel 2.6.22.17 with dvb drivers from mercurial 
> about one week old.
> 

Thanks Andreas.

- Steve

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb