public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: "Daniel Glöckner" <daniel-gl@gmx.net>
To: Andy Walls <awalls@radix.net>
Cc: video4linux-list@redhat.com, v4l-dvb-maintainer@linuxtv.org,
	Trent Piepho <xyzzy@speakeasy.org>,
	Jean Delvare <jdelvare@suse.de>
Subject: Re: [v4l-dvb-maintainer] bttv driver errors
Date: Fri, 22 Aug 2008 22:32:47 +0200	[thread overview]
Message-ID: <20080822203247.GA928@daniel.bse> (raw)
In-Reply-To: <1219407994.2855.24.camel@morgan.walls.org>

On Fri, Aug 22, 2008 at 08:26:34AM -0400, Andy Walls wrote:
> What are the benefits of using the moving average filters before
> decimation?

The benefit is that the upper spectrum is attenuated before it is
mirrored into the lower spectrum by the decimation. After the decimation
you have no way of removing those artifacts in a mathematically correct
way.

There are better FIR filters than 0.5 * x(0) + 0.5 * x(1), which will
avoid aliasing even more and preserve more of the lower spectrum.
This is just the simplest.

Btw., enabling the chroma comb filter in bttv will result in alternating
0.5*x(-2)+0.5*x(0) and 0.5*x(-1)+0.5*x(1) for frame captures and
0.5*x(-1)+0.5*x(0) for field captures. I have once tried to modify
bttv_risc_planar to be closer to MPEG chroma subsampling when the comb
filter is enabled, because I was annoyed by the gray first line.

On Thu, Aug 21, 2008 at 01:50:05AM -0700, Trent Piepho wrote:
> A better question would be how does the bt878 do horizontal and vertical
> scaling?  If you look at the description of ultralock and the number of
> taps avaiable for the vertical scaling filters, the chip must have some
> kind of multi-line buffer before the scaler.  But this buffer, and the
> delay it must introduce, is never mentioned in the datasheet.

The buffer is "mentioned" in figure 2-4 of the Fusion 878A datasheet
available on the Conexant website. Its size can be derived from the
restrictions placed on the luma filters. It should be 768 luma samples.
The decimation then has another full line buffer for luma and chroma
to perform the linear luma interpolation and the chroma comb filter.

  Daniel

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  parent reply	other threads:[~2008-08-22 20:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200808181918.05975.jdelvare@suse.de>
2008-08-18 18:43 ` [v4l-dvb-maintainer] bttv driver errors Trent Piepho
     [not found]   ` <200808202334.20872.jdelvare@suse.de>
2008-08-21  8:50     ` Trent Piepho
     [not found]       ` <200808211114.27290.jdelvare@suse.de>
2008-08-21 22:50         ` Trent Piepho
2008-08-22 12:26           ` [v4l-dvb-maintainer] " Andy Walls
2008-08-22 13:45             ` Andy Walls
2008-08-22 20:32             ` Daniel Glöckner [this message]
2008-08-22 20:54               ` Andy Walls
2008-08-25  0:07             ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080822203247.GA928@daniel.bse \
    --to=daniel-gl@gmx.net \
    --cc=awalls@radix.net \
    --cc=jdelvare@suse.de \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    --cc=xyzzy@speakeasy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox