[linux-dvb] [RFC] cinergyT2 rework final review

[linux-dvb] [RFC] cinergyT2 rework final review

[Thierry Merle]

Hello all,
About the rework from Tomi Orava I stored here:
http://linuxtv.org/hg/~tmerle/cinergyT2

since there seems to be no bug declared with this driver by testers (I
tested this driver on AMD/Intel/ARM platforms for months), it is time for
action.
If I receive no problem report before 19th of October (in one month), I
will push this driver into mainline.
This modification uses the dvb-usb framework, this is

To give you an idea of the code benefit, here is a diffstat of the
cinergyT2 rework patch:
 linux/drivers/media/dvb/cinergyT2/Kconfig        |   85 -
 linux/drivers/media/dvb/cinergyT2/Makefile       |    3
 linux/drivers/media/dvb/cinergyT2/cinergyT2.c    | 1150
---------------------
 linux/drivers/media/dvb/dvb-usb/cinergyT2-core.c |  230 ++++
 linux/drivers/media/dvb/dvb-usb/cinergyT2-fe.c   |  351 ++++++
 linux/drivers/media/dvb/dvb-usb/cinergyT2.h      |   95 +
 linux/drivers/media/dvb/Kconfig                    |    1
 linux/drivers/media/dvb/dvb-usb/Kconfig            |    8
 linux/drivers/media/dvb/dvb-usb/Makefile           |    4
 9 files changed, 688 insertions(+), 1239 deletions(-)

Cheers,
Thierry
-- 
Sent from an ArmedSlack powered NSLU2.


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [RFC] cinergyT2 rework final review

[Patrick Boettcher]

Hi Thierry,

On Fri, 19 Sep 2008, Thierry Merle wrote:

> Hello all,
> About the rework from Tomi Orava I stored here:
> http://linuxtv.org/hg/~tmerle/cinergyT2
>
> since there seems to be no bug declared with this driver by testers (I
> tested this driver on AMD/Intel/ARM platforms for months), it is time for
> action.
> If I receive no problem report before 19th of October (in one month), I
> will push this driver into mainline.

Are you really sure you want to wait until October 19 with that? You heard 
Jonathan this morning, he is expecting a new release every day now, so the 
merge window will start quite soon. Maybe it would be better to shorten 
your deadline in favour of having the driver in-tree for 2.6.28. When it 
is inside it is still possible for at least 1.5 months to fix occuring 
problems.

> This modification uses the dvb-usb framework, this is
>
> To give you an idea of the code benefit, here is a diffstat of the
> cinergyT2 rework patch:
> linux/drivers/media/dvb/cinergyT2/Kconfig        |   85 -
> linux/drivers/media/dvb/cinergyT2/Makefile       |    3
> linux/drivers/media/dvb/cinergyT2/cinergyT2.c    | 1150
> ---------------------
> linux/drivers/media/dvb/dvb-usb/cinergyT2-core.c |  230 ++++
> linux/drivers/media/dvb/dvb-usb/cinergyT2-fe.c   |  351 ++++++
> linux/drivers/media/dvb/dvb-usb/cinergyT2.h      |   95 +
> linux/drivers/media/dvb/Kconfig                    |    1
> linux/drivers/media/dvb/dvb-usb/Kconfig            |    8
> linux/drivers/media/dvb/dvb-usb/Makefile           |    4
> 9 files changed, 688 insertions(+), 1239 deletions(-)

Impressive. It means there are currently around 600 lines boilerplate code 
in the cinergyT2-driver (I like this word ;) )

Patrick.

--
   Mail: patrick.boettcher@desy.de
   WWW:  http://www.wi-bw.tfh-wildau.de/~pboettch/

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [RFC] cinergyT2 rework final review

[Markus Rechberger]

On Fri, Sep 19, 2008 at 8:35 AM, Patrick Boettcher
<patrick.boettcher@desy.de> wrote:
> Hi Thierry,
>
> On Fri, 19 Sep 2008, Thierry Merle wrote:
>
>> Hello all,
>> About the rework from Tomi Orava I stored here:
>> http://linuxtv.org/hg/~tmerle/cinergyT2
>>
>> since there seems to be no bug declared with this driver by testers (I
>> tested this driver on AMD/Intel/ARM platforms for months), it is time for
>> action.
>> If I receive no problem report before 19th of October (in one month), I
>> will push this driver into mainline.
>
> Are you really sure you want to wait until October 19 with that? You heard
> Jonathan this morning, he is expecting a new release every day now, so the
> merge window will start quite soon. Maybe it would be better to shorten
> your deadline in favour of having the driver in-tree for 2.6.28. When it
> is inside it is still possible for at least 1.5 months to fix occuring
> problems.
>
>> This modification uses the dvb-usb framework, this is
>>
>> To give you an idea of the code benefit, here is a diffstat of the
>> cinergyT2 rework patch:
>> linux/drivers/media/dvb/cinergyT2/Kconfig        |   85 -
>> linux/drivers/media/dvb/cinergyT2/Makefile       |    3
>> linux/drivers/media/dvb/cinergyT2/cinergyT2.c    | 1150
>> ---------------------
>> linux/drivers/media/dvb/dvb-usb/cinergyT2-core.c |  230 ++++
>> linux/drivers/media/dvb/dvb-usb/cinergyT2-fe.c   |  351 ++++++
>> linux/drivers/media/dvb/dvb-usb/cinergyT2.h      |   95 +
>> linux/drivers/media/dvb/Kconfig                    |    1
>> linux/drivers/media/dvb/dvb-usb/Kconfig            |    8
>> linux/drivers/media/dvb/dvb-usb/Makefile           |    4
>> 9 files changed, 688 insertions(+), 1239 deletions(-)
>
> Impressive. It means there are currently around 600 lines boilerplate code
> in the cinergyT2-driver (I like this word ;) )
>

there was an intention to redesign the dvb framework (make a v3) with
that driver so it duplicated
alot code from the core.

Markus

> Patrick.
>
> --
>   Mail: patrick.boettcher@desy.de
>   WWW:  http://www.wi-bw.tfh-wildau.de/~pboettch/
>
> _______________________________________________
> linux-dvb mailing list
> linux-dvb@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
>

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [RFC] cinergyT2 rework final review

[Steven Toth]

Patrick Boettcher wrote:
> Hi Thierry,
> 
> On Fri, 19 Sep 2008, Thierry Merle wrote:
> 
>> Hello all,
>> About the rework from Tomi Orava I stored here:
>> http://linuxtv.org/hg/~tmerle/cinergyT2
>>
>> since there seems to be no bug declared with this driver by testers (I
>> tested this driver on AMD/Intel/ARM platforms for months), it is time for
>> action.
>> If I receive no problem report before 19th of October (in one month), I
>> will push this driver into mainline.
> 
> Are you really sure you want to wait until October 19 with that? You heard 
> Jonathan this morning, he is expecting a new release every day now, so the 
> merge window will start quite soon. Maybe it would be better to shorten 
> your deadline in favour of having the driver in-tree for 2.6.28. When it 
> is inside it is still possible for at least 1.5 months to fix occuring 
> problems.

Agreed, shorten and aim for 2.6.28 - especially if you've already done a 
significant amount of personal testing.

- Steve

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [RFC] cinergyT2 rework final review

[Thierry Merle]

> Patrick Boettcher wrote:
>> Hi Thierry,
>>
>> On Fri, 19 Sep 2008, Thierry Merle wrote:
>>
>>> Hello all,
>>> About the rework from Tomi Orava I stored here:
>>> http://linuxtv.org/hg/~tmerle/cinergyT2
>>>
>>> since there seems to be no bug declared with this driver by testers (I
>>> tested this driver on AMD/Intel/ARM platforms for months), it is time
>>> for
>>> action.
>>> If I receive no problem report before 19th of October (in one month), I
>>> will push this driver into mainline.
>>
>> Are you really sure you want to wait until October 19 with that? You
>> heard
>> Jonathan this morning, he is expecting a new release every day now, so
>> the
>> merge window will start quite soon. Maybe it would be better to shorten
>> your deadline in favour of having the driver in-tree for 2.6.28. When it
>> is inside it is still possible for at least 1.5 months to fix occuring
>> problems.
>
> Agreed, shorten and aim for 2.6.28 - especially if you've already done a
> significant amount of personal testing.
>
> - Steve
>
>
OK. In my mind this patch was not a priority and some users reported bugs
but we don't have any news from their part. Maybe buggy users :)
I will wait just a little at least from Tomi and send a pull request to
Mauro within the middle of the next week.

Cheers,
Thierry

-- 
Sent from an ArmedSlack powered NSLU2.


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [RFC] cinergyT2 rework final review

[Tino Keitel]

On Fri, Sep 19, 2008 at 14:34:50 +0200, Thierry Merle wrote:

[...]

> OK. In my mind this patch was not a priority and some users reported bugs
> but we don't have any news from their part. Maybe buggy users :)
> I will wait just a little at least from Tomi and send a pull request to
> Mauro within the middle of the next week.

I had 2 issues:

- irrecord didn't work

- a failure after resume after suspend with the driver loaded, the
  keyboard went crazy. Unloading the driver and unplugging the
  CinergyT2 helped in this case

I don't know if theses issues are still present, though. I don't use the IR
receiver anymore, and always unload the driver before suspend. I'll try
to update to the current driver and re-test.

Regards,
Tino

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [RFC] cinergyT2 rework final review

[Tomi Orava]

Hi,

>> Patrick Boettcher wrote:
>>> Hi Thierry,
>>>
>>> On Fri, 19 Sep 2008, Thierry Merle wrote:
>>>
>>>> Hello all,
>>>> About the rework from Tomi Orava I stored here:
>>>> http://linuxtv.org/hg/~tmerle/cinergyT2
>>>>
>>>> since there seems to be no bug declared with this driver by testers
(I tested this driver on AMD/Intel/ARM platforms for months), it is
time for
>>>> action.
>>>> If I receive no problem report before 19th of October (in one month), I
>>>> will push this driver into mainline.
>>>
>>> Are you really sure you want to wait until October 19 with that? You
heard
>>> Jonathan this morning, he is expecting a new release every day now, so
the
>>> merge window will start quite soon. Maybe it would be better to
shorten your deadline in favour of having the driver in-tree for
2.6.28. When it
>>> is inside it is still possible for at least 1.5 months to fix occuring
problems.
>>
>> Agreed, shorten and aim for 2.6.28 - especially if you've already done
a significant amount of personal testing.
>>
>> - Steve
>>
>>
> OK. In my mind this patch was not a priority and some users reported
bugs but we don't have any news from their part. Maybe buggy users :) I
will wait just a little at least from Tomi and send a pull request to
Mauro within the middle of the next week.

Not much has been happening during the summertime. No new bug reports have
been reported and I never heard again from the person who claimed to have
had problems with this driver in May(?). This driver has been working in
my own use quite well, especially after upgrading the bios to the latest
available version from TerraTec.

Regards,
Tomi Orava


-- 



_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [RFC] cinergyT2 rework final review

[Tomi Orava]

Hi,

> On Fri, Sep 19, 2008 at 14:34:50 +0200, Thierry Merle wrote:
>
> [...]
>
>> OK. In my mind this patch was not a priority and some users reported bugs
>> but we don't have any news from their part. Maybe buggy users :) I will
wait just a little at least from Tomi and send a pull request to Mauro
within the middle of the next week.
>
> I had 2 issues:
>
> - irrecord didn't work
>
> - a failure after resume after suspend with the driver loaded, the
>   keyboard went crazy. Unloading the driver and unplugging the
>   CinergyT2 helped in this case
>
> I don't know if theses issues are still present, though. I don't use the
> IR receiver anymore, and always unload the driver before suspend. I'll
> try to update to the current driver and re-test.

I think that the version in Thierry's repository should contain
the missing key repeat functionality that Thierry added in June.
This should help to get the irrecord running again.

Could you check what is the firmware version in your device ?
Check for the "bcdDevice" keyword with lsusb -v -s <busid>:<devnum> I had
way too many problems with 1.06 firmware version, but the
newer 1.08 seems to be a little bit better in stability.
I do think that this device is certainly not the most stable tuner on
earth but if you don't do suspend/resume with it,
it should work quite fine.

Regards,
Tomi Orava

-- 




-- 



_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [RFC] cinergyT2 rework final review

[Martin Dauskardt]

>This driver has been working in
> my own use quite well, especially after upgrading the bios to the latest
> available version from TerraTec.
> 
> Regards,
> Tomi Orava
what "bios" do you mean? the firmware?

> Could you check what is the firmware version in your device ?
> Check for the "bcdDevice" keyword with lsusb -v -s <busid>:<devnum> I had
> way too many problems with 1.06 firmware version, but the
> newer 1.08 seems to be a little bit better in stability.
I was not aware that this device uses a firmware. Do I have to flash it into 
the box? Is this possible with Linux? Where do I find the firmware?

Greets,
Martin Dauskardt

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [RFC] cinergyT2 rework final review

[Tino Keitel]

On Mon, Sep 22, 2008 at 10:20:42 +0300, Tomi Orava wrote:

[...]

> Could you check what is the firmware version in your device ?
> Check for the "bcdDevice" keyword with lsusb -v -s <busid>:<devnum> I had
> way too many problems with 1.06 firmware version, but the
> newer 1.08 seems to be a little bit better in stability.
> I do think that this device is certainly not the most stable tuner on
> earth but if you don't do suspend/resume with it,
> it should work quite fine.

I have 1.06, but it was rock stable over the years, if I unload the
driver before suspend. And as I use MythTV, the card had pretty much
load (MythTV's EIT crawler).

I just updated to 2.6.27-rc7 and the cinergyT2 driver from
http://linuxtv.org/hg/~tmerle/cinergyT2. Looks good so far.

Regards,
Tino

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [RFC] cinergyT2 rework final review

[Christophe Thommeret]

Le Monday 22 September 2008 21:18:38 Martin Dauskardt, vous avez écrit :
> >This driver has been working in
> > my own use quite well, especially after upgrading the bios to the latest
> > available version from TerraTec.
> >
> > Regards,
> > Tomi Orava
>
> what "bios" do you mean? the firmware?
>
> > Could you check what is the firmware version in your device ?
> > Check for the "bcdDevice" keyword with lsusb -v -s <busid>:<devnum> I had
> > way too many problems with 1.06 firmware version, but the
> > newer 1.08 seems to be a little bit better in stability.
>
> I was not aware that this device uses a firmware. Do I have to flash it
> into the box? Is this possible with Linux? Where do I find the firmware?

See this message:
http://linuxtv.org/pipermail/linux-dvb/2008-September/028939.html



-- 
Christophe Thommeret


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [RFC] cinergyT2 rework final review

[Tomi Orava]

Hi,

Martin Dauskardt wrote:
>> This driver has been working in
>> my own use quite well, especially after upgrading the bios to the latest
>> available version from TerraTec.
>>
>> Regards,
>> Tomi Orava
> what "bios" do you mean? the firmware?

Yes, I meant the usb device firmware.

> 
>> Could you check what is the firmware version in your device ?
>> Check for the "bcdDevice" keyword with lsusb -v -s <busid>:<devnum> I had
>> way too many problems with 1.06 firmware version, but the
>> newer 1.08 seems to be a little bit better in stability.
> I was not aware that this device uses a firmware. Do I have to flash it into 
> the box? Is this possible with Linux? Where do I find the firmware?

You can get the latest firmware from Terratec ftp-site:
ftp://ftp.terratec.net/Receiver/CinergyT2/Update/History/CinergyT2_Firmware_Update_1.08.exe

The very same directory also contains the original proprietary (NOT
BDA) windows drivers which are needed before you can use the
included flash loader. Unfortutenaly, I don't know any way to do the
update in Linux.

Regards,
Tomi Orava


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb