[linux-dvb] em28xx-audio: HVR-900 B3C0 - ID 2040:6502 Hauppauge (audio clicking)

[linux-dvb] em28xx-audio: HVR-900 B3C0 - ID 2040:6502 Hauppauge (audio clicking)

[Wiktor Grębla]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Hi.

After some diffing I've finally managed to get rid of "audio clicking"
problem which could be heard when using analog tv or composite input
of my HVR-900. Additionally, after Mauro's suggestion, I found it
necessary to change the audio amux value for composite input from 1 to
3.

Patch against linux-dvb hg repo attached. I hope it's trivial enough
to be applied quickly. I've been using my tuner for three days without
any sound issues so far.

Cheers,
W.

-- 
Talkers are no good doers.
http://greblus.net/djangoblog/

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: em28xx_audio_clicking_and_composite_amux_change.diff --]
[-- Type: text/x-diff; name=em28xx_audio_clicking_and_composite_amux_change.diff, Size: 1341 bytes --]

diff -ur v4l-dvb-old/linux/drivers/media/video/em28xx/em28xx-audio.c v4l-dvb-new/linux/drivers/media/video/em28xx/em28xx-audio.c
--- v4l-dvb-old/linux/drivers/media/video/em28xx/em28xx-audio.c	2008-09-21 21:26:04.000000000 +0200
+++ v4l-dvb-new/linux/drivers/media/video/em28xx/em28xx-audio.c	2008-09-21 21:26:24.000000000 +0200
@@ -127,10 +127,10 @@
 
 			if (oldptr + length >= runtime->buffer_size) {
 				unsigned int cnt =
-				    runtime->buffer_size - oldptr - 1;
+				    runtime->buffer_size - oldptr;
 				memcpy(runtime->dma_area + oldptr * stride, cp,
 				       cnt * stride);
-				memcpy(runtime->dma_area, cp + cnt,
+				memcpy(runtime->dma_area, cp + cnt * stride,
 				       length * stride - cnt * stride);
 			} else {
 				memcpy(runtime->dma_area + oldptr * stride, cp,
diff -ur v4l-dvb-old/linux/drivers/media/video/em28xx/em28xx-cards.c v4l-dvb-new/linux/drivers/media/video/em28xx/em28xx-cards.c
--- v4l-dvb-old/linux/drivers/media/video/em28xx/em28xx-cards.c	2008-09-21 21:26:04.000000000 +0200
+++ v4l-dvb-new/linux/drivers/media/video/em28xx/em28xx-cards.c	2008-09-21 21:26:31.000000000 +0200
@@ -578,7 +578,7 @@
 		}, {
 			.type     = EM28XX_VMUX_COMPOSITE1,
 			.vmux     = TVP5150_COMPOSITE1,
-			.amux     = 1,
+			.amux     = 3,
 		}, {
 			.type     = EM28XX_VMUX_SVIDEO,
 			.vmux     = TVP5150_SVIDEO,

[-- Attachment #3: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] em28xx-audio: HVR-900 B3C0 - ID 2040:6502 Hauppauge (audio clicking)

[Douglas Schilling Landgraf]

Hello Wiktor,

On Tue, 23 Sep 2008 21:10:06 +0200
"Wiktor Grębla" <greblus@gmail.com> wrote:

> Hi.
> 
> After some diffing I've finally managed to get rid of "audio clicking"
> problem which could be heard when using analog tv or composite input
> of my HVR-900. Additionally, after Mauro's suggestion, I found it
> necessary to change the audio amux value for composite input from 1 to
> 3.
> 
> Patch against linux-dvb hg repo attached. I hope it's trivial enough
> to be applied quickly. 

For sure, I'll check your patch. Thanks for your
help.

> I've been using my tuner for three days without
> any sound issues so far.

Cool!

Cheers,
Douglas

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb