From: Alan Cox <alan@redhat.com>
To: Alexey Klimov <klimov.linux@gmail.com>
Cc: video4linux-list@redhat.com
Subject: Re: radio-mr800 usb driver
Date: Thu, 25 Sep 2008 07:39:32 -0400 [thread overview]
Message-ID: <20080925113932.GA21999@shell.devel.redhat.com> (raw)
In-Reply-To: <208cbae30809250429m64c1c552ud18ff5064602e3c0@mail.gmail.com>
On Thu, Sep 25, 2008 at 03:29:55PM +0400, Alexey Klimov wrote:
> First of all - sorry for my english.
Your English is fine...
> Driver works fine with kradio & gnomeradio applications. Works normal
> under Linux kernel 2.6.27-rc6 (released 9 Sep 2008), compiles without
> warnings with gcc version 4.3.1 (Gentoo 4.3.1-r1 p1.1) on
> x86-architecture machine.
Looks nice and clean to me. No obvious mistakes. Probably the warn()
statements should include the module name so people know which module
produced them if they ever want to file a bug.
Alan
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-09-25 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 11:29 radio-mr800 usb driver Alexey Klimov
2008-09-25 11:39 ` Alan Cox [this message]
2008-09-28 0:21 ` Alexey Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080925113932.GA21999@shell.devel.redhat.com \
--to=alan@redhat.com \
--cc=klimov.linux@gmail.com \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox