From: Dmitri Belimov <d.belimov@gmail.com>
To: video4linux-list@redhat.com
Subject: Re: [REGRESSION, PATCH] I2C remote controls on saa7134
Date: Mon, 29 Sep 2008 12:25:40 +1000 [thread overview]
Message-ID: <20080929122540.154fcbbc@glory.loctelecom.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
Hi All.
This is patch for solve this regression. Load ir-kbd-i2c module when remote is i2c type.
diff -r 8e6cda021e0e linux/drivers/media/video/saa7134/saa7134-core.c
--- a/linux/drivers/media/video/saa7134/saa7134-core.c Fri Sep 26 11:29:03 2008 +0200
+++ b/linux/drivers/media/video/saa7134/saa7134-core.c Mon Sep 29 06:20:59 2008 +1000
@@ -760,6 +760,10 @@
irq2_mask |= SAA7134_IRQ2_INTE_GPIO18A;
}
+ if (dev->has_remote == SAA7134_REMOTE_I2C) {
+ request_module("ir-kbd-i2c");
+ }
+
saa_writel(SAA7134_IRQ1, 0);
saa_writel(SAA7134_IRQ2, irq2_mask);
Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>
With my best regards, Dmitry.
[-- Attachment #2: saa7134_ir-kbd-i2c.patch --]
[-- Type: text/x-patch, Size: 542 bytes --]
diff -r 8e6cda021e0e linux/drivers/media/video/saa7134/saa7134-core.c
--- a/linux/drivers/media/video/saa7134/saa7134-core.c Fri Sep 26 11:29:03 2008 +0200
+++ b/linux/drivers/media/video/saa7134/saa7134-core.c Mon Sep 29 06:20:59 2008 +1000
@@ -760,6 +760,10 @@
irq2_mask |= SAA7134_IRQ2_INTE_GPIO18A;
}
+ if (dev->has_remote == SAA7134_REMOTE_I2C) {
+ request_module("ir-kbd-i2c");
+ }
+
saa_writel(SAA7134_IRQ1, 0);
saa_writel(SAA7134_IRQ2, irq2_mask);
Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>
[-- Attachment #3: Type: text/plain, Size: 164 bytes --]
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
reply other threads:[~2008-09-29 2:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080929122540.154fcbbc@glory.loctelecom.ru \
--to=d.belimov@gmail.com \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox