[PATCH 0/3] stk-webcam updates

[PATCH 0/3] stk-webcam updates

[David Ellingsworth]

The following series of patches correct issues identified in
stk-webcam. The patches are as follows:

1. stkwebcam: fix crash on close after disconnect
2. stkwebcam: free via video_device release callback
3. stkwebcam: simplify access to stk_camera struct

The first patch in this series is a bug fix. If it is possible to
merge this patch into 2.6.27 I highly recommend it as this bug has
existed for quite some time. The second patch restructures the driver
and removes the now unnecessary reference count on the stk_camera
struct. The third patch simplifies the driver in several areas
removing several unnecessary branches.

These patchs should apply cleanly against the working branch of the
git v4l-dvb tree. Each of the patches will be submitted independently.

Regards,

David Ellingsworth

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [PATCH 0/3] stk-webcam updates

[Jaime Velasco Juan]

El lun. 29 de sep. de 2008, a las 20:21:04 -0400, David Ellingsworth escribió:
> The following series of patches correct issues identified in
> stk-webcam. The patches are as follows:
> 
> 1. stkwebcam: fix crash on close after disconnect
> 2. stkwebcam: free via video_device release callback
> 3. stkwebcam: simplify access to stk_camera struct
> 
> The first patch in this series is a bug fix. If it is possible to
> merge this patch into 2.6.27 I highly recommend it as this bug has
> existed for quite some time. The second patch restructures the driver
> and removes the now unnecessary reference count on the stk_camera
> struct. The third patch simplifies the driver in several areas
> removing several unnecessary branches.
> 
> These patchs should apply cleanly against the working branch of the
> git v4l-dvb tree. Each of the patches will be submitted independently.
> 
> Regards,
> 
> David Ellingsworth

ACK

Regards,
Jaime

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [PATCH 0/3] stk-webcam updates

[David Ellingsworth]

On Tue, Sep 30, 2008 at 12:00 PM, Jaime Velasco Juan
<jsagarribay@gmail.com> wrote:
> El lun. 29 de sep. de 2008, a las 20:21:04 -0400, David Ellingsworth escribió:
>> The following series of patches correct issues identified in
>> stk-webcam. The patches are as follows:
>>
>> 1. stkwebcam: fix crash on close after disconnect
>> 2. stkwebcam: free via video_device release callback
>> 3. stkwebcam: simplify access to stk_camera struct
>>
>> The first patch in this series is a bug fix. If it is possible to
>> merge this patch into 2.6.27 I highly recommend it as this bug has
>> existed for quite some time. The second patch restructures the driver
>> and removes the now unnecessary reference count on the stk_camera
>> struct. The third patch simplifies the driver in several areas
>> removing several unnecessary branches.
>>
>> These patchs should apply cleanly against the working branch of the
>> git v4l-dvb tree. Each of the patches will be submitted independently.
>>
>> Regards,
>>
>> David Ellingsworth
>
> ACK
>
> Regards,
> Jaime
>

Mauro,

Please apply these for 2.6.28

Regards,

David Ellingsworth

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [PATCH 0/3] stk-webcam updates

[Mauro Carvalho Chehab]

Hi David,

On Fri, 10 Oct 2008 15:29:15 -0400
"David Ellingsworth" <david@identd.dyndns.org> wrote:

> On Tue, Sep 30, 2008 at 12:00 PM, Jaime Velasco Juan
> <jsagarribay@gmail.com> wrote:
> > El lun. 29 de sep. de 2008, a las 20:21:04 -0400, David Ellingsworth escribió:
> >> The following series of patches correct issues identified in
> >> stk-webcam. The patches are as follows:
> >>
> >> 1. stkwebcam: fix crash on close after disconnect
> >> 2. stkwebcam: free via video_device release callback
> >> 3. stkwebcam: simplify access to stk_camera struct
> >>
> >> The first patch in this series is a bug fix. If it is possible to
> >> merge this patch into 2.6.27 I highly recommend it as this bug has
> >> existed for quite some time. The second patch restructures the driver
> >> and removes the now unnecessary reference count on the stk_camera
> >> struct. The third patch simplifies the driver in several areas
> >> removing several unnecessary branches.
> >>
> >> These patchs should apply cleanly against the working branch of the
> >> git v4l-dvb tree. Each of the patches will be submitted independently.

There were some API changes at V4L that also touched at stkwebcam. Due to that,
I'm getting some rejects on your patch series (this is at the first patch):

 patch -p1 -i /tmp/editdiff.CvlYZA/patch.diff -d linux
patching file drivers/media/video/stk-webcam.c
Hunk #1 succeeded at 561 (offset -15 lines).
Hunk #2 FAILED at 703.
1 out of 2 hunks FAILED -- saving rejects to file drivers/media/video/stk-webcam.c.rej

Could you please re-generate it?

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list