From: Matthias Schwarzott <zzam@gentoo.org>
To: linux-dvb@linuxtv.org
Cc: Manu Abraham <abraham.manu@gmail.com>
Subject: [linux-dvb] commit 9344:aa3a67b658e8 (DVB-Core update) breaks tuning of cx24123
Date: Mon, 27 Oct 2008 20:23:23 +0100 [thread overview]
Message-ID: <200810272023.23513.zzam@gentoo.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
Hi Manu, hi Steven!
It seems an update of dvb-core breaks tuning of cx24123.
After updating to latest v4l-dvb the nova-s plus card just did no longer lock
to any channel. So I bisected it, and found this commit:
changeset: 9344:aa3a67b658e8
parent: 9296:e2a8b9b9c294
user: Manu Abraham <manu@linuxtv.org>
date: Tue Oct 14 23:34:07 2008 +0400
summary: DVB-Core update
http://linuxtv.org/hg/v4l-dvb/rev/aa3a67b658e8
It basically did update the dvb-kernel-thread and enhanced the code using
get_frontend_algo.
The codepath when get_frontend_algo returns *_ALGO_HW stayed the same, only
one line got removed: params = &fepriv->parameter
Just re-adding that line made my card working again. Either this was lost, or
the last two lines using "params" should also be converted to directly
use "&fepriv->parameters".
Regards
Matthias
[-- Attachment #2: fix-tune-algo-hw.diff --]
[-- Type: text/x-diff, Size: 348 bytes --]
--- v4l-dvb.orig/linux/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ v4l-dvb/linux/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -584,6 +584,7 @@ restart:
if (fepriv->state & FESTATE_RETUNE) {
dprintk("%s: Retune requested, FESTATE_RETUNE\n", __func__);
+ params = &fepriv->parameters;
fepriv->state = FESTATE_TUNED;
}
[-- Attachment #3: Type: text/plain, Size: 150 bytes --]
_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
next reply other threads:[~2008-10-27 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 19:23 Matthias Schwarzott [this message]
2008-10-27 19:41 ` [linux-dvb] commit 9344:aa3a67b658e8 (DVB-Core update) breaks tuning of cx24123 Manu Abraham
2008-10-27 19:50 ` Matthias Schwarzott
2008-10-27 19:59 ` Manu Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810272023.23513.zzam@gentoo.org \
--to=zzam@gentoo.org \
--cc=abraham.manu@gmail.com \
--cc=linux-dvb@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox