[PATCH 0/1] radio-mr800: fix unplug

[PATCH 0/1] radio-mr800: fix unplug

[Alexey Klimov]

Hello, all

This patch fix such thing. When you listening the radio with you
user-space application(kradio/gnomeradio/mplayer/etc) and suddenly you
unplug the device from usb port and then close application or change
frequency of the radio - a lot of oopses appear in dmesg. I also had big
problems with stability of kernel(different memory leaks, lockings) in
~30% of cases when using mplayer trying to reproduce this bug.

This thing happens with dsbr100 radio and radio-mr800. I told about this
thing to Douglas Schilling Landgraf and then he suggested right decision
for dsbr100. He told me that he get ideas of preventing this bug from
Tobias radio-si470x driver. Hopefully this bug didn't show up in
radio-si470x. Well, i used Douglas suggestion and code of si470x and
made this patch.

Douglas said that he's going to create patch for dsbr100.

Patch places a lof of safety checks in functions, adds disconnect_lock
mutex and changes disconnect and release functions of module. May be
it's good to add it to 2.6.28 because it fixes an issue.
I tested this thing under 2.6.28-rc5.

-- 
Best regards, Klimov Alexey


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [PATCH 0/1] radio-mr800: fix unplug

[Douglas Schilling Landgraf]

Hello Alexey,

On Wed, 19 Nov 2008 03:35:55 +0300
Alexey Klimov <klimov.linux@gmail.com> wrote:

> Hello, all
> 
> This patch fix such thing. When you listening the radio with you
> user-space application(kradio/gnomeradio/mplayer/etc) and suddenly you
> unplug the device from usb port and then close application or change
> frequency of the radio - a lot of oopses appear in dmesg. I also had
> big problems with stability of kernel(different memory leaks,
> lockings) in ~30% of cases when using mplayer trying to reproduce
> this bug.
 
> This thing happens with dsbr100 radio and radio-mr800. I told about
> this thing to Douglas Schilling Landgraf and then he suggested right
> decision for dsbr100. He told me that he get ideas of preventing this
> bug from Tobias radio-si470x driver. Hopefully this bug didn't show
> up in radio-si470x. Well, i used Douglas suggestion and code of
> si470x and made this patch.
> 
> Douglas said that he's going to create patch for dsbr100.

humm, since you already fixed radio-mr800 and I'm working with other
developers to improve em28xx... Are you interested to make a patch to
fix dsbr100?

Cheers,
Douglas

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [PATCH 0/1] radio-mr800: fix unplug

[Alexey Klimov]

Hello, Douglas

On Thu, Nov 20, 2008 at 6:31 AM, Douglas Schilling Landgraf
<dougsland@gmail.com> wrote:
> Hello Alexey,
>
> On Wed, 19 Nov 2008 03:35:55 +0300
> Alexey Klimov <klimov.linux@gmail.com> wrote:
>
>> Hello, all
>>
>> This patch fix such thing. When you listening the radio with you
>> user-space application(kradio/gnomeradio/mplayer/etc) and suddenly you
>> unplug the device from usb port and then close application or change
>> frequency of the radio - a lot of oopses appear in dmesg. I also had
>> big problems with stability of kernel(different memory leaks,
>> lockings) in ~30% of cases when using mplayer trying to reproduce
>> this bug.
>
>> This thing happens with dsbr100 radio and radio-mr800. I told about
>> this thing to Douglas Schilling Landgraf and then he suggested right
>> decision for dsbr100. He told me that he get ideas of preventing this
>> bug from Tobias radio-si470x driver. Hopefully this bug didn't show
>> up in radio-si470x. Well, i used Douglas suggestion and code of
>> si470x and made this patch.
>>
>> Douglas said that he's going to create patch for dsbr100.
>
> humm, since you already fixed radio-mr800 and I'm working with other
> developers to improve em28xx... Are you interested to make a patch to
> fix dsbr100?
>
> Cheers,
> Douglas
>

Well, if you okay with that and if this patch (for mr800) is right - i
can make patch for dsbr100. Currently, i don't have access to this
device for a few days. So, if i don't post this patch to this list in
a week - please contact with me.


-- 
Best regards, Klimov Alexey

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [PATCH 0/1] radio-mr800: fix unplug

[Douglas Schilling Landgraf]

Hello,

On Thu, 20 Nov 2008 10:42:40 +0300
"Alexey Klimov" <klimov.linux@gmail.com> wrote:

> Hello, Douglas
> 
> On Thu, Nov 20, 2008 at 6:31 AM, Douglas Schilling Landgraf
> <dougsland@gmail.com> wrote:
> > Hello Alexey,
> >
> > On Wed, 19 Nov 2008 03:35:55 +0300
> > Alexey Klimov <klimov.linux@gmail.com> wrote:
> >
> >> Hello, all
> >>
> >> This patch fix such thing. When you listening the radio with you
> >> user-space application(kradio/gnomeradio/mplayer/etc) and suddenly
> >> you unplug the device from usb port and then close application or
> >> change frequency of the radio - a lot of oopses appear in dmesg. I
> >> also had big problems with stability of kernel(different memory
> >> leaks, lockings) in ~30% of cases when using mplayer trying to
> >> reproduce this bug.
> >
> >> This thing happens with dsbr100 radio and radio-mr800. I told about
> >> this thing to Douglas Schilling Landgraf and then he suggested
> >> right decision for dsbr100. He told me that he get ideas of
> >> preventing this bug from Tobias radio-si470x driver. Hopefully
> >> this bug didn't show up in radio-si470x. Well, i used Douglas
> >> suggestion and code of si470x and made this patch.
> >>
> >> Douglas said that he's going to create patch for dsbr100.
> >
> > humm, since you already fixed radio-mr800 and I'm working with other
> > developers to improve em28xx... Are you interested to make a patch
> > to fix dsbr100?
> >
> > Cheers,
> > Douglas
> >
> 
> Well, if you okay with that and if this patch (for mr800) is right - i
> can make patch for dsbr100. 

Seems ok.

> Currently, i don't have access to this
> device for a few days. So, if i don't post this patch to this list in
> a week - please contact with me.

Ok.

Cheers,
Douglas

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list