From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mBCCPmUF013477 for ; Fri, 12 Dec 2008 07:25:48 -0500 Received: from mail-qy0-f21.google.com (mail-qy0-f21.google.com [209.85.221.21]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id mBCCPYMe009863 for ; Fri, 12 Dec 2008 07:25:35 -0500 Received: by qyk14 with SMTP id 14so1565394qyk.3 for ; Fri, 12 Dec 2008 04:25:34 -0800 (PST) Date: Fri, 12 Dec 2008 10:25:29 -0200 From: Douglas Schilling Landgraf To: Robert William Fuller Message-ID: <20081212102529.77b4e105@gmail.com> In-Reply-To: <49422453.8080000@gmail.com> References: <208cbae30812112203o6be4974epb87b3810e2de3581@mail.gmail.com> <49422453.8080000@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "video4linux-list@redhat.com" Subject: Re: [REVIEW PATCH 13/14] OMAP: CAM: Add Lens Driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: Hello Robert, On Fri, 12 Dec 2008 03:44:03 -0500 Robert William Fuller wrote: > Alexey Klimov wrote: > > > > > I didn't ever see two "=" in one line in code. Is it okay ? > > If you do not understand the C programming language, why are you in a > position to review code? humm, everyone can review patches and give their opinions. The technique of reviewing code will always help programmers to improve their knowledge and helps the quality of modules or even of subsystem. On the other hand, if the author of patch or maintainer will accept those suggestions is other case. IMO, the above answer discourage reviewing code, please don't do that again. Cheers, Douglas -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list