Re: zr36067 no longer loads automatically (regression)

[Jean Delvare <khali@linux-fr.org>]

On Fri, 9 Jan 2009 09:20:18 -0200, Mauro Carvalho Chehab wrote:
> 
> On Thu, 8 Jan 2009 22:01:08 -0800 (PST)
> Trent Piepho <xyzzy@speakeasy.org> wrote:
> 
> > On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> > > On Thu, 8 Jan 2009 13:20:19 -0800 (PST)
> > > Trent Piepho <xyzzy@speakeasy.org> wrote:
> > > > On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote:
> > > > It doesn't seem like any other driver needs to protect the module device
> > > > table with an ifdef.
> > >
> > > However, Zoran driver doesn't rely on pci_register_driver(). Instead, it uses a
> > > while() loop to probe for Zoran devices:
> > >
> > > static int __devinit
> > > find_zr36057 (void)
> > > {
> > > 	...
> > >
> > >         zoran_num = 0;
> > >         while (zoran_num < BUZ_MAX &&
> > >                (dev = pci_get_device(PCI_VENDOR_ID_ZORAN, PCI_DEVICE_ID_ZORAN_36057, dev)) != NULL) {
> > > 	...
> > > }
> > 
> > Yuck, why don't we fix this instead?
> 
> This will be much better.
> 
> > Here's an initial test.  I haven't yet found my dc10+ to test it with.
> 
> Unfortunately, I don't have any Zoran card here to test.
> 
> Jean, it is up to you to test Trent's patch.

Will do as soon as I manage to apply it.

-- 
Jean Delvare