From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from zone0.gcu-squad.org ([212.85.147.21]:38177 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbZAILoS (ORCPT ); Fri, 9 Jan 2009 06:44:18 -0500 Date: Fri, 9 Jan 2009 12:43:57 +0100 From: Jean Delvare To: Mauro Carvalho Chehab Cc: Trent Piepho , V4L and DVB maintainers , Linux Media Mailing List Subject: Re: zr36067 no longer loads automatically (regression) Message-ID: <20090109124357.549acef6@hyperion.delvare> In-Reply-To: <20090109092018.59a6d9eb@pedra.chehab.org> References: <20090108143315.2b564dfe@hyperion.delvare> <20090108175627.0ebd9f36@pedra.chehab.org> <20090108193923.580fcd5b@pedra.chehab.org> <20090109092018.59a6d9eb@pedra.chehab.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, 9 Jan 2009 09:20:18 -0200, Mauro Carvalho Chehab wrote: > > On Thu, 8 Jan 2009 22:01:08 -0800 (PST) > Trent Piepho wrote: > > > On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote: > > > On Thu, 8 Jan 2009 13:20:19 -0800 (PST) > > > Trent Piepho wrote: > > > > On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote: > > > > It doesn't seem like any other driver needs to protect the module device > > > > table with an ifdef. > > > > > > However, Zoran driver doesn't rely on pci_register_driver(). Instead, it uses a > > > while() loop to probe for Zoran devices: > > > > > > static int __devinit > > > find_zr36057 (void) > > > { > > > ... > > > > > > zoran_num = 0; > > > while (zoran_num < BUZ_MAX && > > > (dev = pci_get_device(PCI_VENDOR_ID_ZORAN, PCI_DEVICE_ID_ZORAN_36057, dev)) != NULL) { > > > ... > > > } > > > > Yuck, why don't we fix this instead? > > This will be much better. > > > Here's an initial test. I haven't yet found my dc10+ to test it with. > > Unfortunately, I don't have any Zoran card here to test. > > Jean, it is up to you to test Trent's patch. Will do as soon as I manage to apply it. -- Jean Delvare