Re: zr36067 no longer loads automatically (regression)

[Jean Delvare <khali@linux-fr.org>]

Hi Trent,

On Fri, 9 Jan 2009 12:20:54 -0800 (PST), Trent Piepho wrote:
> On Fri, 9 Jan 2009, Trent Piepho wrote:
> > Here is a new version against latest v4l-dvb sources.  Jean, are you trying
> > to apply against the kernel tree?  These patches are against the v4l-dvb Hg
> > repository which isn't quite the same as what's in the kernel.
> >
> > I have some more patches at http://linuxtv.org/hg/~tap/zoran
> 
> Forgot the patch

Patch tested successfully. Nice cleanup! I wanted to do it for quite
some time but could never find the time.

Acked-by: Jean Delvare <khali@linux-fr.org>

With just one suggestion:

> (...)
> +static int __init zoran_init(void)
>  {
>  	int i;
> 
> (...)
> +	i = pci_register_driver(&zoran_driver);
> +	if (i) {
> +		dprintk(1,
> +			KERN_ERR
> +			"%s: Unable to register ZR36057 driver\n",
> +			ZORAN_NAME);
> +		return i;

"i" could be renamed to "err" for clarity.

>  	}
> 
>  	return 0;
>  }

Thanks,
-- 
Jean Delvare