From: Jean Delvare <khali@linux-fr.org>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] saa7146_i2c: saa7146_i2c_transfer() wrong?
Date: Sun, 1 Feb 2009 11:55:14 +0100 [thread overview]
Message-ID: <20090201115514.380984b7@hyperion.delvare> (raw)
In-Reply-To: <498481B5.4030702@gmail.com>
On Sat, 31 Jan 2009 17:52:05 +0100, Roel Kluin wrote:
> vi drivers/media/common/saa7146_i2c.c +292
>
> in saa7146_i2c_transfer(..., int retries)
> {
> int address_err = 0;
> do {
> ...
> if (...)
> address_err++;
> ...
> } while (retries--);
>
> /* if every retry had an address error, exit right away */
> if (address_err == retries) {
> goto out;
> }
> ...
> }
> this is wrong, isn't it?
Yes, it looks pretty wrong, however the linux-i2c list isn't the right
place to discuss this.
--
Jean Delvare
prev parent reply other threads:[~2009-02-01 10:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 16:52 [PATCH] saa7146_i2c: saa7146_i2c_transfer() wrong? Roel Kluin
2009-02-01 10:55 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090201115514.380984b7@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox