From: Jean-Francois Moine <moinejf@free.fr>
To: Adam Baker <linux@baker-net.org.uk>
Cc: kilgota@banach.math.auburn.edu,
Alan Stern <stern@rowland.harvard.edu>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] Make sure gspca cleans up USB resources during disconnect
Date: Thu, 5 Feb 2009 12:39:47 +0100 [thread overview]
Message-ID: <20090205123947.0ba06e44@free.fr> (raw)
In-Reply-To: <200902042207.44867.linux@baker-net.org.uk>
On Wed, 4 Feb 2009 22:07:44 +0000
Adam Baker <linux@baker-net.org.uk> wrote:
> Thank You - If it wasn't for your work on gspca I'd still be using a
> buggy old driver that had no chance of making it to main line.
OK. It seems everything works fine with your webcam(s) (and the other
ones).
I added some more checks of the device presence and fixed a bit the API.
Are you ready to send me a patch for the driver?
I have just a remark: in sd_init (probe/resume), you do
dev->work_thread = NULL;
INIT_WORK(&dev->work_struct, sq905_dostream);
The first line is not needed, and the second should be done in
sd_config (probe only - on resume, the work will remain the same).
Also, the BUG_ON in sd_start is not needed.
About finepix, indeed, it asks for fixes, but also, it would be
simplified with a workqueue...
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2009-02-05 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 23:13 [PATCH] Make sure gspca cleans up USB resources during disconnect Adam Baker
2009-02-04 1:12 ` kilgota
2009-02-04 16:40 ` Jean-Francois Moine
2009-02-04 22:07 ` Adam Baker
2009-02-05 11:39 ` Jean-Francois Moine [this message]
2009-02-05 18:59 ` kilgota
2009-02-05 19:51 ` Jean-Francois Moine
2009-02-05 21:54 ` kilgota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205123947.0ba06e44@free.fr \
--to=moinejf@free.fr \
--cc=kilgota@banach.math.auburn.edu \
--cc=linux-media@vger.kernel.org \
--cc=linux@baker-net.org.uk \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox