From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from zone0.gcu-squad.org ([212.85.147.21]:17330 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276AbZCCVdj (ORCPT ); Tue, 3 Mar 2009 16:33:39 -0500 Date: Tue, 3 Mar 2009 22:33:25 +0100 From: Jean Delvare To: Trent Piepho Cc: Andy Walls , linux-media@vger.kernel.org Subject: Re: General protection fault on rmmod cx8800 Message-ID: <20090303223325.7a6f0f94@hyperion.delvare> In-Reply-To: References: <20090215214108.34f31c39@hyperion.delvare> <20090302133936.00899692@hyperion.delvare> <1236003365.3071.6.camel@palomino.walls.org> <20090302170349.18c8fd75@hyperion.delvare> <20090302200513.7fc3568e@hyperion.delvare> <20090302225235.5d6d47ce@hyperion.delvare> <20090303131633.52dbb472@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On Tue, 3 Mar 2009 12:14:06 -0800 (PST), Trent Piepho wrote: > On Tue, 3 Mar 2009, Jean Delvare wrote: > > On Tue, 3 Mar 2009 01:40:00 -0800 (PST), Trent Piepho wrote: > > > On Mon, 2 Mar 2009, Jean Delvare wrote: > > > In 2.6.20 delayed_work was split from work_struct. The concept of delayed > > > work was already there and schedule_delayed_work() hasn't changed. I think > > > this can also be handled with a compat.h change that defines delayed_work > > > to work_struct. That will only be a problem on pre 2.6.20 kernels if some > > > code decides to define identifiers named work_struct and delayed_work in > > > the same scope. There are currently no identifier named delayed_work in > > > any driver and one driver (sq905) has a structure member named > > > work_struct. So I think it'll be ok. > > > > Wow, I didn't expect that many different compatibility issues. This > > goes beyond the time I am ready to spend on it, I'm afraid. > > I already have a patch for compat.h that handles the last remaining issue. > You don't have to do anything. Ah, very nice then. Please push it to the v4l-dvb repository so that I can send my own patch. I will also fix the 3 other drivers that have the same bug (ir-kbd-i2c, saa6588 and em28xx-input). -- Jean Delvare