From: Jean Delvare <khali@linux-fr.org>
To: Trent Piepho <xyzzy@speakeasy.org>
Cc: LMML <linux-media@vger.kernel.org>
Subject: Re: [PATCH] cx88: Prevent general protection fault on rmmod
Date: Thu, 5 Mar 2009 14:48:14 +0100 [thread overview]
Message-ID: <20090305144814.6168dcd8@hyperion.delvare> (raw)
In-Reply-To: <Pine.LNX.4.58.0903050141050.24268@shell2.speakeasy.net>
On Thu, 5 Mar 2009 01:43:55 -0800 (PST), Trent Piepho wrote:
> On Thu, 5 Mar 2009, Jean Delvare wrote:
> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20)
> > struct work_struct work;
> > struct timer_list timer;
> > +#else
> > + struct delayed_work work;
> > +#endif
>
> You don't need this compat stuff. compat.h will take are of it for you.
> Just code it like you would for the latest kernel. The only thing you need
> to worry about is the way the third argument of the work function went
> away, but the ifdef that's already there takes care of it.
OK, thanks. I'll resend updated patches soon.
--
Jean Delvare
next prev parent reply other threads:[~2009-03-05 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 9:38 [PATCH] cx88: Prevent general protection fault on rmmod Jean Delvare
2009-03-05 9:43 ` Trent Piepho
2009-03-05 13:48 ` Jean Delvare [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-07 10:42 Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090305144814.6168dcd8@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=linux-media@vger.kernel.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox