Re: S4 hang with uvcvideo causing "Unlink after no-IRQ? Controller is probably using the wrong IRQ."

[Brandon Philips <brandon@ifup.org>]

On 16:50 Fri 13 Mar 2009, Alan Stern wrote:
> On Fri, 13 Mar 2009, Brandon Philips wrote:
> 
> > On 14:03 Fri 13 Mar 2009, Alan Stern wrote:
> > > On Fri, 13 Mar 2009, Brandon Philips wrote:
> > > 
> > > > > Okay, not much information there but it's a start.  Here's a more 
> > > > > informative patch to try instead.
> > > > 
> > > > Here is the log:
> > > >  http://ifup.org/~philips/467317/pearl-alan-debug-2.log
> > > 
> > > I still can't tell what's happening.  Here's yet another patch.
> > 
> > http://ifup.org/~philips/467317/pearl-alan-debug-3.log
> 
> I think I see the problem; the patch below is an attempted fix.
> Hopefully it will get your system working.

That fixes it, thanks. This was originally found in a 2.6.27 based
Kernel so the fix can go off to stable@ too.

Tested-by: Brandon Philips <bphilips@suse.de>

> Index: usb-2.6/drivers/usb/host/ehci-q.c
> ===================================================================
> --- usb-2.6.orig/drivers/usb/host/ehci-q.c
> +++ usb-2.6/drivers/usb/host/ehci-q.c
> @@ -1127,7 +1127,7 @@ static void start_unlink_async (struct e
>  	prev->qh_next = qh->qh_next;
>  	wmb ();
>  
> -	if (unlikely (ehci_to_hcd(ehci)->state == HC_STATE_HALT)) {
> +	if (unlikely(!HC_IS_RUNNING(ehci_to_hcd(ehci)->state))) {
>  		/* if (unlikely (qh->reclaim != 0))
>  		 *	this will recurse, probably not much
>  		 */
>