From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Alexey Klimov <klimov.linux@gmail.com>
Cc: Alessio Igor Bogani <abogani@texware.it>,
LKML <linux-kernel@vger.kernel.org>,
linux-media@vger.kernel.org, video4linux-list@redhat.com
Subject: Re: [PATCH] radio-mr800.c: Missing mutex include
Date: Fri, 27 Mar 2009 07:11:43 -0300 [thread overview]
Message-ID: <20090327071143.59619399@pedra.chehab.org> (raw)
In-Reply-To: <1237326128.2141.17.camel@tux.localhost>
On Wed, 18 Mar 2009 00:42:08 +0300
Alexey Klimov <klimov.linux@gmail.com> wrote:
> On Tue, 2009-03-17 at 22:00 +0100, Alessio Igor Bogani wrote:
> > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
> > pulled in indirectly by one of the headers it already includes, the
> > right thing is to include it directly.
>
>
> Hello, Alessio
>
> Patch looks okay for my eyes.
> If it useful it should be applied.
>
> Thank you!
>
> Mauro, if patch is okay please apply it.
> If you need my ack - here it is:
> Acked-by: Alexey Klimov <klimov.linux@gmail.com>
If the mutex.h were already included by another kernel header, I don't see why
to include it again. If a later patch remove the mutex.h from the header, then
the patch author should take care of this change anyway.
Cheers,
Mauro
prev parent reply other threads:[~2009-03-27 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 21:00 [PATCH] radio-mr800.c: Missing mutex include Alessio Igor Bogani
2009-03-17 21:42 ` Alexey Klimov
2009-03-27 10:11 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327071143.59619399@pedra.chehab.org \
--to=mchehab@infradead.org \
--cc=abogani@texware.it \
--cc=klimov.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox