From: Adam Baker <linux@baker-net.org.uk>
To: linux-media@vger.kernel.org, Hans de Goede <j.w.r.degoede@hhs.nl>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
"Jean-Francois Moine" <moinejf@free.fr>
Cc: kilgota@banach.math.auburn.edu, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH v2 1/4] Sensor orientation reporting
Date: Sun, 29 Mar 2009 23:17:10 +0100 [thread overview]
Message-ID: <200903292317.10249.linux@baker-net.org.uk> (raw)
In-Reply-To: <200903292309.31267.linux@baker-net.org.uk>
Add support to the SQ-905 driver to pass back to user space the
sensor orientation information obtained from the camera during init.
Modifies gspca and the videodev2.h header to create the necessary
API.
Signed-off-by: Adam Baker <linux@baker-net.org.uk>
---
diff -r d8d701594f71 linux/drivers/media/video/gspca/gspca.c
--- a/linux/drivers/media/video/gspca/gspca.c Sun Mar 29 08:45:36 2009 +0200
+++ b/linux/drivers/media/video/gspca/gspca.c Sun Mar 29 23:00:08 2009 +0100
@@ -1147,6 +1147,7 @@
if (input->index != 0)
return -EINVAL;
input->type = V4L2_INPUT_TYPE_CAMERA;
+ input->status = gspca_dev->cam.input_flags;
strncpy(input->name, gspca_dev->sd_desc->name,
sizeof input->name);
return 0;
diff -r d8d701594f71 linux/drivers/media/video/gspca/gspca.h
--- a/linux/drivers/media/video/gspca/gspca.h Sun Mar 29 08:45:36 2009 +0200
+++ b/linux/drivers/media/video/gspca/gspca.h Sun Mar 29 23:00:08 2009 +0100
@@ -56,6 +56,7 @@
* - cannot be > MAX_NURBS
* - when 0 and bulk_size != 0 means
* 1 URB and submit done by subdriver */
+ u32 input_flags; /* value for ENUM_INPUT status flags */
};
struct gspca_dev;
diff -r d8d701594f71 linux/drivers/media/video/gspca/sq905.c
--- a/linux/drivers/media/video/gspca/sq905.c Sun Mar 29 08:45:36 2009 +0200
+++ b/linux/drivers/media/video/gspca/sq905.c Sun Mar 29 23:00:08 2009 +0100
@@ -360,6 +360,12 @@
gspca_dev->cam.nmodes = ARRAY_SIZE(sq905_mode);
if (!(ident & SQ905_HIRES_MASK))
gspca_dev->cam.nmodes--;
+
+ if (ident & SQ905_ORIENTATION_MASK)
+ gspca_dev->cam.input_flags = V4L2_IN_ST_VFLIP;
+ else
+ gspca_dev->cam.input_flags = V4L2_IN_ST_VFLIP |
+ V4L2_IN_ST_HFLIP;
return 0;
}
diff -r d8d701594f71 linux/include/linux/videodev2.h
--- a/linux/include/linux/videodev2.h Sun Mar 29 08:45:36 2009 +0200
+++ b/linux/include/linux/videodev2.h Sun Mar 29 23:00:08 2009 +0100
@@ -737,6 +737,11 @@
#define V4L2_IN_ST_NO_SIGNAL 0x00000002
#define V4L2_IN_ST_NO_COLOR 0x00000004
+/* field 'status' - sensor orientation */
+/* If sensor is mounted upside down set both bits */
+#define V4L2_IN_ST_HFLIP 0x00000010 /* Output is flipped horizontally
*/
+#define V4L2_IN_ST_VFLIP 0x00000020 /* Output is flipped vertically */
+
/* field 'status' - analog */
#define V4L2_IN_ST_NO_H_LOCK 0x00000100 /* No horizontal sync lock */
#define V4L2_IN_ST_COLOR_KILL 0x00000200 /* Color killer is active */
next prev parent reply other threads:[~2009-03-29 22:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 22:09 [PATCH v2 0/4] Sensor orientation reporting Adam Baker
2009-03-29 22:17 ` Adam Baker [this message]
2009-03-29 22:22 ` [PATCH v2 2/4] Specify SHELL in documentation Makefile Adam Baker
2009-03-29 22:25 ` [PATCH v2 3/4] Document the orientation flags in ENUMINPUT Adam Baker
2009-03-29 22:28 ` [PATCH v2 4/4] Add support to libv4l to use orientation from VIDIOC_ENUMINPUT Adam Baker
2009-03-30 8:30 ` Hans de Goede
2009-04-05 12:12 ` Mauro Carvalho Chehab
2009-04-10 11:34 ` Hans de Goede
2009-03-29 22:55 ` [PATCH v2 1/4] Sensor orientation reporting Hans Verkuil
2009-03-29 23:58 ` Theodore Kilgore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903292317.10249.linux@baker-net.org.uk \
--to=linux@baker-net.org.uk \
--cc=hverkuil@xs4all.nl \
--cc=j.w.r.degoede@hhs.nl \
--cc=kilgota@banach.math.auburn.edu \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox