From: Jean Delvare <khali@linux-fr.org>
To: Mike Isely <isely@isely.net>
Cc: LMML <linux-media@vger.kernel.org>
Subject: Re: [PATCH] pvrusb2: Don't use the internal i2c client list
Date: Sat, 2 May 2009 08:55:43 +0200 [thread overview]
Message-ID: <20090502085543.6d6920c3@hyperion.delvare> (raw)
In-Reply-To: <Pine.LNX.4.64.0905012223040.15541@cnc.isely.net>
On Fri, 1 May 2009 22:25:28 -0500 (CDT), Mike Isely wrote:
> On Thu, 30 Apr 2009, Mike Isely wrote:
>
> > On Thu, 30 Apr 2009, Jean Delvare wrote:
> >
> > > The i2c core used to maintain a list of client for each adapter. This
> > > is a duplication of what the driver core already does, so this list
> > > will be removed as part of a future cleanup. Anyone using this list
> > > must stop doing so.
> > >
> > > For pvrusb2, I propose the following change, which should lead to an
> > > equally informative output. The only difference is that i2c clients
> > > which are not a v4l2 subdev won't show up, but I guess this case is
> > > not supposed to happen anyway.
> >
> > It will happen for anything i2c used by v4l which itself is not really a
> > part of v4l. That would include, uh, lirc.
> >
> > I will review and test this first chance I get which should be tomorrow.
> >
>
> I've merged and tested this patch. It behaves as expected.
>
> I'm putting together a bunch of pvrusb2 changesets right now anyway.
> I've pulled this one into the collection, with appropriate attributions
> of course.
Excellent, thank you!
--
Jean Delvare
prev parent reply other threads:[~2009-05-02 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 15:35 [PATCH] pvrusb2: Don't use the internal i2c client list Jean Delvare
2009-05-01 0:27 ` Mike Isely
2009-05-02 3:25 ` Mike Isely
2009-05-02 6:55 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090502085543.6d6920c3@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=isely@isely.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox