* [PATCH] libv4l: spca508 UV inversion
@ 2009-05-05 9:08 Jean-Francois Moine
2009-05-10 7:11 ` Jean-Francois Moine
0 siblings, 1 reply; 3+ messages in thread
From: Jean-Francois Moine @ 2009-05-05 9:08 UTC (permalink / raw)
To: Hans de Goede; +Cc: Linux Media
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
Hello Hans,
People with a spca508 webcam report a color inversion in the images.
Here is a simple patch to fix this problem.
Cheers.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
[-- Attachment #2: patch.pat --]
[-- Type: application/octet-stream, Size: 693 bytes --]
libv4l: UV color inversion in spca508 decoding.
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
diff -r e7894eacbca7 v4l2-apps/libv4l/libv4lconvert/libv4lconvert.c
--- a/v4l2-apps/libv4l/libv4lconvert/libv4lconvert.c Tue May 05 10:01:11 2009 +0200
+++ b/v4l2-apps/libv4l/libv4lconvert/libv4lconvert.c Tue May 05 11:03:02 2009 +0200
@@ -585,7 +585,7 @@
v4lconvert_spca505_to_yuv420(src, d, width, height, yvu);
break;
case V4L2_PIX_FMT_SPCA508:
- v4lconvert_spca508_to_yuv420(src, d, width, height, yvu);
+ v4lconvert_spca508_to_yuv420(src, d, width, height, !yvu);
break;
case V4L2_PIX_FMT_SN9C20X_I420:
v4lconvert_sn9c20x_to_yuv420(src, d, width, height, yvu);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libv4l: spca508 UV inversion
2009-05-05 9:08 [PATCH] libv4l: spca508 UV inversion Jean-Francois Moine
@ 2009-05-10 7:11 ` Jean-Francois Moine
2009-05-10 7:24 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Jean-Francois Moine @ 2009-05-10 7:11 UTC (permalink / raw)
To: Hans de Goede; +Cc: Linux Media
On Tue, 5 May 2009 11:08:46 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:
> People with a spca508 webcam report a color inversion in the images.
> Here is a simple patch to fix this problem.
Hello Hans,
Sorry, this is not true for all webcams. Please, don't apply the patch!
Cheers.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libv4l: spca508 UV inversion
2009-05-10 7:11 ` Jean-Francois Moine
@ 2009-05-10 7:24 ` Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2009-05-10 7:24 UTC (permalink / raw)
To: Jean-Francois Moine; +Cc: Linux Media
On 05/10/2009 09:11 AM, Jean-Francois Moine wrote:
> On Tue, 5 May 2009 11:08:46 +0200
> Jean-Francois Moine<moinejf@free.fr> wrote:
>
>> People with a spca508 webcam report a color inversion in the images.
>> Here is a simple patch to fix this problem.
>
> Hello Hans,
>
> Sorry, this is not true for all webcams. Please, don't apply the patch!
>
Ok,
Let me know when you've found out to which webcams it does apply, I guess we
need a new pixformat define for those ?
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-10 7:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-05 9:08 [PATCH] libv4l: spca508 UV inversion Jean-Francois Moine
2009-05-10 7:11 ` Jean-Francois Moine
2009-05-10 7:24 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox