* [patch 1/6] radio-mr800.c: missing mutex include
@ 2009-06-10 19:44 akpm
2009-06-10 23:21 ` Alexey Klimov
0 siblings, 1 reply; 4+ messages in thread
From: akpm @ 2009-06-10 19:44 UTC (permalink / raw)
To: mchehab; +Cc: linux-media, akpm, abogani
From: Alessio Igor Bogani <abogani@texware.it>
radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
pulled in indirectly by one of the headers it already includes, the right
thing is to include it directly.
Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/media/radio/radio-mr800.c | 1 +
1 file changed, 1 insertion(+)
diff -puN drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include drivers/media/radio/radio-mr800.c
--- a/drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include
+++ a/drivers/media/radio/radio-mr800.c
@@ -64,6 +64,7 @@
#include <media/v4l2-ioctl.h>
#include <linux/usb.h>
#include <linux/version.h> /* for KERNEL_VERSION MACRO */
+#include <linux/mutex.h>
/* driver and module definitions */
#define DRIVER_AUTHOR "Alexey Klimov <klimov.linux@gmail.com>"
_
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/6] radio-mr800.c: missing mutex include
2009-06-10 19:44 [patch 1/6] radio-mr800.c: missing mutex include akpm
@ 2009-06-10 23:21 ` Alexey Klimov
2009-06-10 23:23 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Klimov @ 2009-06-10 23:21 UTC (permalink / raw)
To: akpm; +Cc: mchehab, linux-media, abogani
On Wed, Jun 10, 2009 at 11:44 PM, <akpm@linux-foundation.org> wrote:
> From: Alessio Igor Bogani <abogani@texware.it>
>
> radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
> pulled in indirectly by one of the headers it already includes, the right
> thing is to include it directly.
It was already applied to v4l-dvb tree (and probably to v4l git tree).
Thanks,
--
regards, Klimov Alexey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/6] radio-mr800.c: missing mutex include
2009-06-10 23:21 ` Alexey Klimov
@ 2009-06-10 23:23 ` Andrew Morton
2009-06-11 0:36 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2009-06-10 23:23 UTC (permalink / raw)
To: Alexey Klimov; +Cc: mchehab, linux-media, abogani
On Thu, 11 Jun 2009 03:21:36 +0400 Alexey Klimov <klimov.linux@gmail.com> wrote:
> On Wed, Jun 10, 2009 at 11:44 PM, <akpm@linux-foundation.org> wrote:
> > From: Alessio Igor Bogani <abogani@texware.it>
> >
> > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
> > pulled in indirectly by one of the headers it already includes, the right
> > thing is to include it directly.
>
> It was already applied to v4l-dvb tree (and probably to v4l git tree).
It isn't in today's linux-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/6] radio-mr800.c: missing mutex include
2009-06-10 23:23 ` Andrew Morton
@ 2009-06-11 0:36 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2009-06-11 0:36 UTC (permalink / raw)
To: Andrew Morton; +Cc: Alexey Klimov, linux-media, abogani
Em Wed, 10 Jun 2009 16:23:44 -0700
Andrew Morton <akpm@linux-foundation.org> escreveu:
> On Thu, 11 Jun 2009 03:21:36 +0400 Alexey Klimov <klimov.linux@gmail.com> wrote:
>
> > On Wed, Jun 10, 2009 at 11:44 PM, <akpm@linux-foundation.org> wrote:
> > > From: Alessio Igor Bogani <abogani@texware.it>
> > >
> > > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
> > > pulled in indirectly by one of the headers it already includes, the right
> > > thing is to include it directly.
> >
> > It was already applied to v4l-dvb tree (and probably to v4l git tree).
>
> It isn't in today's linux-next.
Hi Andrew,
Thanks for remind us about those 6 patches. I'll double check if those are
already on my staging tree. If they aren't I'll apply or comment.
Since I'm currently in the proccess updating my trees, I should be adding
several pending patches on my -git tree, probably in time for tomorrow's
linux-next tree.
Cheers,
Mauro
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-06-11 0:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-10 19:44 [patch 1/6] radio-mr800.c: missing mutex include akpm
2009-06-10 23:21 ` Alexey Klimov
2009-06-10 23:23 ` Andrew Morton
2009-06-11 0:36 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox