From: David Brownell <david-b@pacbell.net>
To: davinci-linux-open-source@linux.davincidsp.com
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
hvaibhav@ti.com, linux-omap@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH (V2)] TVP514x: Migration to sub-device framework
Date: Sun, 14 Jun 2009 12:50:04 -0700 [thread overview]
Message-ID: <200906141250.04455.david-b@pacbell.net> (raw)
In-Reply-To: <200906141214.38355.hverkuil@xs4all.nl>
On Sunday 14 June 2009, Hans Verkuil wrote:
> > +#define dump_reg(sd, reg, val) \
> > do { \
> > - val = tvp514x_read_reg(client, reg); \
> > - v4l_info(client, "Reg(0x%.2X): 0x%.2X\n", reg, val); \
> > + val = tvp514x_read_reg(sd, reg); \
> > + v4l2_info(sd, "Reg(0x%.2X): 0x%.2X\n", reg, val); \
> > } while (0)
>
> Why not turn this into a static inline function? Much better than a macro.
IMO, too big for either. Make it a real function.
prev parent reply other threads:[~2009-06-14 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 18:31 [PATCH (V2)] TVP514x: Migration to sub-device framework hvaibhav
2009-06-14 10:14 ` Hans Verkuil
2009-06-14 12:44 ` Hans Verkuil
2009-06-14 14:32 ` tcm825x.c: migrating to sub-device framework? (was: TVP514x: Migration to sub-device framework) Hans Verkuil
2009-06-15 8:45 ` tcm825x.c: migrating to sub-device framework? Sakari Ailus
2009-06-14 19:50 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906141250.04455.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hvaibhav@ti.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox