From: Matthias Schwarzott <zzam@gentoo.org>
To: linux-media@vger.kernel.org
Cc: Jan Nikitenko <jan.nikitenko@gmail.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Antti Palosaari <crope@iki.fi>,
Christopher Pascoe <c.pascoe@itee.uq.edu.au>
Subject: Re: [PATCH] zl10353 and qt1010: fix stack corruption bug
Date: Wed, 17 Jun 2009 14:26:28 +0200 [thread overview]
Message-ID: <200906171426.29468.zzam@gentoo.org> (raw)
In-Reply-To: <4A38DA79.70707@gmail.com>
On Mittwoch, 17. Juni 2009, Jan Nikitenko wrote:
>
> Or we could use sizeof, like this:
> char buf[sizeof("00: ") - 1 + 16 * (sizeof("00 ") - 1) + 1]
> or
> char buf[sizeof("00: 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f
> ")] but it is not very readable in my opinion either.
>
> Maybe the best way would be to avoid the need for temporal buffer
> completely by directly using printk in a loop, that is only the first
> printk with KERN_DEBUG, followed by sequence of printk with registers dump
> and final printk with end of line (but isn't a printk without KERN_
> facility coding style problem as well?).
>
Exactly for this case, line continuation, there is KERN_CONT defined.
Regards
Matthias
next prev parent reply other threads:[~2009-06-17 12:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 7:52 AVerTV Volar Black HD: i2c oops in warm state on mips Jan Nikitenko
2009-06-05 8:55 ` Patrick Boettcher
2009-06-05 15:36 ` Antti Palosaari
2009-06-09 22:39 ` Jan Nikitenko
2009-06-10 0:11 ` Antti Palosaari
2009-06-10 6:21 ` [PATCH] zl10353 and qt1010: fix stack corruption bug Jan Nikitenko
2009-06-15 19:01 ` Antti Palosaari
2009-06-16 18:59 ` Mauro Carvalho Chehab
2009-06-17 11:58 ` Jan Nikitenko
2009-06-17 12:26 ` Matthias Schwarzott [this message]
2009-06-17 13:18 ` Mauro Carvalho Chehab
2009-06-18 11:11 ` [PATCH v2] " Jan Nikitenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906171426.29468.zzam@gentoo.org \
--to=zzam@gentoo.org \
--cc=c.pascoe@itee.uq.edu.au \
--cc=crope@iki.fi \
--cc=jan.nikitenko@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox