From: Matthias Schwarzott <zzam@gentoo.org>
To: linux-media@vger.kernel.org
Subject: lsmod path hardcoded in v4l/Makefile
Date: Mon, 22 Jun 2009 16:36:24 +0200 [thread overview]
Message-ID: <200906221636.25006.zzam@gentoo.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
Hi list!
It seems the path to lsmod tool is hardcoded in the Makefile for out-of-tree
building of v4l-dvb.
Now at least gentoo has moved lsmod from /sbin to /bin.
Additionally it is bad style (or at least I am told so), to not rely on $PATH
but hardcode pathes for tools that should be in $PATH.
So the attached patch removes the hardcoded /sbin from the lsmod call.
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Regards
Matthias
[-- Attachment #2: v4l-dvb-lsmod-path.diff --]
[-- Type: text/x-diff, Size: 438 bytes --]
diff -r 65ec132f20df v4l/Makefile
--- a/v4l/Makefile Wed May 27 15:53:00 2009 -0300
+++ b/v4l/Makefile Thu May 28 10:05:04 2009 +0200
@@ -196,7 +196,7 @@
inst-m := $(obj-m)
endif
-v4l_modules := $(shell /sbin/lsmod|cut -d' ' -f1 ) $(patsubst %.ko,%,$(inst-m))
+v4l_modules := $(shell lsmod|cut -d' ' -f1 ) $(patsubst %.ko,%,$(inst-m))
#################################################
# locales seem to cause trouble sometimes.
next reply other threads:[~2009-06-22 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 14:36 Matthias Schwarzott [this message]
2009-06-22 22:42 ` lsmod path hardcoded in v4l/Makefile Andy Walls
2009-06-22 23:01 ` Trent Piepho
2009-06-23 7:51 ` Matthias Schwarzott
2009-06-22 23:39 ` Theodore Kilgore
2009-06-23 8:24 ` Matthias Schwarzott
2009-06-23 7:50 ` Matthias Schwarzott
2009-06-23 19:29 ` Trent Piepho
2009-07-21 7:14 ` Matthias Schwarzott
2009-07-28 1:07 ` Mauro Carvalho Chehab
2009-07-28 7:30 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906221636.25006.zzam@gentoo.org \
--to=zzam@gentoo.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox