From: Matthias Schwarzott <zzam@gentoo.org>
To: linux-media@vger.kernel.org
Cc: Andy Walls <awalls@radix.net>
Subject: Re: lsmod path hardcoded in v4l/Makefile
Date: Tue, 23 Jun 2009 09:50:26 +0200 [thread overview]
Message-ID: <200906230950.26287.zzam@gentoo.org> (raw)
In-Reply-To: <1245710531.3190.7.camel@palomino.walls.org>
On Dienstag, 23. Juni 2009, Andy Walls wrote:
> On Mon, 2009-06-22 at 16:36 +0200, Matthias Schwarzott wrote:
> > Hi list!
> >
> > It seems the path to lsmod tool is hardcoded in the Makefile for
> > out-of-tree building of v4l-dvb.
> > Now at least gentoo has moved lsmod from /sbin to /bin.
> > Additionally it is bad style (or at least I am told so), to not rely on
> > $PATH but hardcode pathes for tools that should be in $PATH.
>
> It's a potential security hole to rely on $PATH instead of absolute
> paths when running a command as root.
Shouldn't $PATH of root be considered safe? Else the distro or the system
setup is doing something worse, and can't be improved by using fixed pathes
in some scripts and Makefiles.
Regards
Matthias
next prev parent reply other threads:[~2009-06-23 7:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 14:36 lsmod path hardcoded in v4l/Makefile Matthias Schwarzott
2009-06-22 22:42 ` Andy Walls
2009-06-22 23:01 ` Trent Piepho
2009-06-23 7:51 ` Matthias Schwarzott
2009-06-22 23:39 ` Theodore Kilgore
2009-06-23 8:24 ` Matthias Schwarzott
2009-06-23 7:50 ` Matthias Schwarzott [this message]
2009-06-23 19:29 ` Trent Piepho
2009-07-21 7:14 ` Matthias Schwarzott
2009-07-28 1:07 ` Mauro Carvalho Chehab
2009-07-28 7:30 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906230950.26287.zzam@gentoo.org \
--to=zzam@gentoo.org \
--cc=awalls@radix.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox