From: Matthias Schwarzott <zzam@gentoo.org>
To: linux-media@vger.kernel.org
Cc: Trent Piepho <xyzzy@speakeasy.org>, Andy Walls <awalls@radix.net>
Subject: Re: lsmod path hardcoded in v4l/Makefile
Date: Tue, 23 Jun 2009 09:51:48 +0200 [thread overview]
Message-ID: <200906230951.48983.zzam@gentoo.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0906221558510.6411@shell2.speakeasy.net>
On Dienstag, 23. Juni 2009, Trent Piepho wrote:
> On Mon, 22 Jun 2009, Andy Walls wrote:
> > On Mon, 2009-06-22 at 16:36 +0200, Matthias Schwarzott wrote:
> > > Hi list!
> > >
> > > It seems the path to lsmod tool is hardcoded in the Makefile for
> > > out-of-tree building of v4l-dvb.
> > > Now at least gentoo has moved lsmod from /sbin to /bin.
>
> Won't your patch cause breakage for everyone who hasn't moved lsmod from
> /sbin and doesn't have sbin in the path? Which was, and perhaps still is,
> the most common situation? It would be better to do something that does
> not break things that used to work.
root without sbin in path is bad and broken, isn't it?
If you really think this is too common, we could add
PATH=/sbin:/bin:$PATH
at the start of the Makefile.
Regards
Matthias
next prev parent reply other threads:[~2009-06-23 7:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 14:36 lsmod path hardcoded in v4l/Makefile Matthias Schwarzott
2009-06-22 22:42 ` Andy Walls
2009-06-22 23:01 ` Trent Piepho
2009-06-23 7:51 ` Matthias Schwarzott [this message]
2009-06-22 23:39 ` Theodore Kilgore
2009-06-23 8:24 ` Matthias Schwarzott
2009-06-23 7:50 ` Matthias Schwarzott
2009-06-23 19:29 ` Trent Piepho
2009-07-21 7:14 ` Matthias Schwarzott
2009-07-28 1:07 ` Mauro Carvalho Chehab
2009-07-28 7:30 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906230951.48983.zzam@gentoo.org \
--to=zzam@gentoo.org \
--cc=awalls@radix.net \
--cc=linux-media@vger.kernel.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox