Re: [PATCH 0/2] gspca sn9c20x subdriver rev2

[Jean-Francois Moine <moinejf@free.fr>]

On Fri, 17 Jul 2009 16:51:41 -0400
Brian Johnson <brijohn@gmail.com> wrote:

> Mauro,
> Here is the updated version of the gspca sn9c20x subdriver.
> 
> I've removed the custom debugging support and replaced it with support
> for the v4l2 debugging ioctls. The first patch in this set adds
> support to the gspca core for those ioctls. Also included are the
> fixes Hans sent in his last email.
> 
> Regards,
> Brian Johnson

Hello Brian and Mauro,

Thanks, Brian. I have just a few remarks:

- in the 1st patch, in gspca.c, why is the get_chip_ident check needed
  in vidioc_g_register / vidioc_s_register)?

- in the 1st patch, in gspca.h, the operations set/get_register in
  the sd descriptor should not exist if not CONFIG_VIDEO_ADV_DEBUG.

- in the 2nd patch, I would have preferred hexadecimal letters in lower
  case.

- in the 2nd patch, the list of the new handled webcams
  (linux/Documentation/video4linux/gspca.txt) is lacking.

Anyway, this is not important and may be done later.

So, Mauro, if it is OK for you (don't confirm), I will handle these
patch series.

Cheers.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/