Re: lsmod path hardcoded in v4l/Makefile

[Matthias Schwarzott <zzam@gentoo.org>]

On Dienstag, 23. Juni 2009, Trent Piepho wrote:
> On Tue, 23 Jun 2009, Matthias Schwarzott wrote:
> > > On Mon, 2009-06-22 at 16:36 +0200, Matthias Schwarzott wrote:
> > > > It seems the path to lsmod tool is hardcoded in the Makefile for
> > > > out-of-tree building of v4l-dvb.
> >
> > Shouldn't $PATH of root be considered safe? Else the distro or the system
>
> I believe make will set the variable whenever the makefile is used, even
> when building as non-root.
>
> It turns out that it was just lsmod with no path originally, but Michael
> Krufky changed it back in 2005 (commit b0e7b40744ef) to have a hardcoded
> path.  Then later in commit c91e7f84a1d6 the only use of 'v4l_modules' was
> deleted, so we can just delete this line and not worry about sbin and
> paths.
>
> Mauro,
>
> Please pull from http://linuxtv.org/hg/~tap/fix
>
> for the following changeset:
>
> build: Remove module list cruft
> http://linuxtv.org/hg/~tap/fix?cmd=changeset;node=fb228bb1ad9f

Hi Mauro!

is there any reason to not pull this besides time?

Regards
Matthias