public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: "Aleksandr V. Piskunov" <aleksandr.v.piskunov@gmail.com>
To: Andy Walls <awalls@radix.net>
Cc: Jean Delvare <khali@linux-fr.org>,
	"Aleksandr V. Piskunov" <aleksandr.v.piskunov@gmail.com>,
	Jarod Wilson <jarod@wilsonet.com>,
	linux-media@vger.kernel.org,
	Oldrich Jedlicka <oldium.pro@seznam.cz>,
	hverkuil@xs4all.nl
Subject: Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels
Date: Mon, 5 Oct 2009 01:23:47 +0300	[thread overview]
Message-ID: <20091004222347.GA31609@moon> (raw)
In-Reply-To: <1254584660.3169.25.camel@palomino.walls.org>

On Sat, Oct 03, 2009 at 11:44:20AM -0400, Andy Walls wrote:
> Aleksandr and Jean,
> 
> Zdrastvoitye & Bonjour,
> 
> To support the AVerMedia M166's IR microcontroller in ivtv and
> ir-kbd-i2c with the new i2c binding model, I have added 3 changesets in
> 
> 	http://linuxtv.org/hg/~awalls/ivtv
> 

Now the last step to the decent support of M116 remote.

I spent hours banging my head against the wall, controller just doesn't
give a stable keypresses, skips a lot of them. Increasing polling interval
from default 100 ms to 400-500 ms helps a bit, but it only masks the
problem. Decreasing polling interval below 50ms makes it skip virtually
90% of keypresses.

Basicly during the I2C operation that reads scancode, controller seems
to stop processing input from IR sensor, resulting a loss of keypress.

So the solution(?) I found was to decrease the udelay in
ivtv_i2c_algo_template from 10 to 5. Guess it just doubles the frequency
of ivtv i2c bus or something like that. Problem went away, IR controller
is now working as expected.

So question is:
1) Is it ok to decrease udelay for this board?
2) If yes, how to do it right?

  parent reply	other threads:[~2009-10-04 22:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-03 15:44 [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels Andy Walls
2009-10-04  8:31 ` Aleksandr V. Piskunov
2009-10-04  8:44   ` Jean Delvare
2009-10-04  9:26     ` Aleksandr V. Piskunov
2009-10-04 20:41       ` Andy Walls
2009-10-04 22:39         ` Aleksandr V. Piskunov
2009-10-04 20:44   ` Andy Walls
2009-10-04  8:54 ` Jean Delvare
2009-10-04 11:33   ` Aleksandr V. Piskunov
2009-10-04 21:07     ` Andy Walls
2009-10-04 20:11   ` Andy Walls
2009-10-05 21:24     ` Jean Delvare
2009-10-04 22:23 ` Aleksandr V. Piskunov [this message]
2009-10-05  1:54   ` Andy Walls
2009-10-05  8:29     ` Jean Delvare
2009-10-05 10:36       ` Andy Walls
2009-10-05  8:50     ` Aleksandr V. Piskunov
2009-10-05  9:04       ` Jean Delvare
2009-10-05 10:02         ` Aleksandr V. Piskunov
2009-10-05 13:56           ` Devin Heitmueller
2009-10-07 17:26       ` Oldrich Jedlicka
2009-10-05 18:45   ` Oldrich Jedlicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091004222347.GA31609@moon \
    --to=aleksandr.v.piskunov@gmail.com \
    --cc=awalls@radix.net \
    --cc=hverkuil@xs4all.nl \
    --cc=jarod@wilsonet.com \
    --cc=khali@linux-fr.org \
    --cc=linux-media@vger.kernel.org \
    --cc=oldium.pro@seznam.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox