[PATCH] videobuf-dma-contig.c: add missing #include

[PATCH] videobuf-dma-contig.c: add missing #include

[Martin Michlmayr]

media/video/videobuf-dma-contig.c fails to compile on ARM Versatile
like this:
 | videobuf-dma-contig.c: In function ‘videobuf_dma_contig_user_get’:
 | videobuf-dma-contig.c:139: error: dereferencing pointer to incomplete type
 | videobuf-dma-contig.c:184: error: dereferencing pointer to incomplete type
 | make[8]: *** [drivers/media/video/videobuf-dma-contig.o] Error 1

Looking at the preprocessed source, I noticed that there was no definition
for struct task_struct.

Signed-off-by: Martin Michlmayr <tbm@cyrius.com>

--- a/drivers/media/video/videobuf-dma-contig.c	2009-10-31 10:22:42.000000000 +0000
+++ b/drivers/media/video/videobuf-dma-contig.c	2009-10-31 10:24:40.000000000 +0000
@@ -19,6 +19,7 @@
 #include <linux/mm.h>
 #include <linux/pagemap.h>
 #include <linux/dma-mapping.h>
+#include <linux/sched.h>
 #include <media/videobuf-dma-contig.h>
 
 struct videobuf_dma_contig_memory {

-- 
Martin Michlmayr
http://www.cyrius.com/

Re: [PATCH] videobuf-dma-contig.c: add missing #include

[Martin Michlmayr]

Are there any comments regarding the build fix I submitted?  This
issue is still there, as you can see at
http://www.xs4all.nl/~hverkuil/logs/Tuesday.log

* Martin Michlmayr <tbm@cyrius.com> [2009-10-31 10:28]:
> media/video/videobuf-dma-contig.c fails to compile on ARM Versatile
> like this:
>  | videobuf-dma-contig.c: In function ‘videobuf_dma_contig_user_get’:
>  | videobuf-dma-contig.c:139: error: dereferencing pointer to incomplete type
>  | videobuf-dma-contig.c:184: error: dereferencing pointer to incomplete type
>  | make[8]: *** [drivers/media/video/videobuf-dma-contig.o] Error 1
> 
> Looking at the preprocessed source, I noticed that there was no definition
> for struct task_struct.
> 
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
> 
> --- a/drivers/media/video/videobuf-dma-contig.c	2009-10-31 10:22:42.000000000 +0000
> +++ b/drivers/media/video/videobuf-dma-contig.c	2009-10-31 10:24:40.000000000 +0000
> @@ -19,6 +19,7 @@
>  #include <linux/mm.h>
>  #include <linux/pagemap.h>
>  #include <linux/dma-mapping.h>
> +#include <linux/sched.h>
>  #include <media/videobuf-dma-contig.h>
>  
>  struct videobuf_dma_contig_memory {
> 
> -- 
> Martin Michlmayr
> http://www.cyrius.com/

-- 
Martin Michlmayr
http://www.cyrius.com/

RE: [PATCH] videobuf-dma-contig.c: add missing #include

[Hiremath, Vaibhav]

> -----Original Message-----
> From: linux-media-owner@vger.kernel.org [mailto:linux-media-
> owner@vger.kernel.org] On Behalf Of Martin Michlmayr
> Sent: Wednesday, November 11, 2009 9:24 PM
> To: linux-media@vger.kernel.org
> Cc: Mauro Carvalho Chehab
> Subject: Re: [PATCH] videobuf-dma-contig.c: add missing #include
> 
> Are there any comments regarding the build fix I submitted?  This
> issue is still there, as you can see at
> http://www.xs4all.nl/~hverkuil/logs/Tuesday.log
> 
[Hiremath, Vaibhav] Tested by me, and it is required, since this is breaking the build. Should get merged.

Thanks,
Vaibhav

> * Martin Michlmayr <tbm@cyrius.com> [2009-10-31 10:28]:
> > media/video/videobuf-dma-contig.c fails to compile on ARM
> Versatile
> > like this:
> >  | videobuf-dma-contig.c: In function
> 'videobuf_dma_contig_user_get':
> >  | videobuf-dma-contig.c:139: error: dereferencing pointer to
> incomplete type
> >  | videobuf-dma-contig.c:184: error: dereferencing pointer to
> incomplete type
> >  | make[8]: *** [drivers/media/video/videobuf-dma-contig.o] Error
> 1
> >
> > Looking at the preprocessed source, I noticed that there was no
> definition
> > for struct task_struct.
> >
> > Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
> >
> > --- a/drivers/media/video/videobuf-dma-contig.c	2009-10-31
> 10:22:42.000000000 +0000
> > +++ b/drivers/media/video/videobuf-dma-contig.c	2009-10-31
> 10:24:40.000000000 +0000
> > @@ -19,6 +19,7 @@
> >  #include <linux/mm.h>
> >  #include <linux/pagemap.h>
> >  #include <linux/dma-mapping.h>
> > +#include <linux/sched.h>
> >  #include <media/videobuf-dma-contig.h>
> >
> >  struct videobuf_dma_contig_memory {
> >
> > --
> > Martin Michlmayr
> > http://www.cyrius.com/
> 
> --
> Martin Michlmayr
> http://www.cyrius.com/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] videobuf-dma-contig.c: add missing #include

[Guennadi Liakhovetski]

On Wed, 11 Nov 2009, Martin Michlmayr wrote:

> Are there any comments regarding the build fix I submitted?  This
> issue is still there, as you can see at
> http://www.xs4all.nl/~hverkuil/logs/Tuesday.log

Oh, I'm afraid, I've unwillingly stolen your patch:

http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=d5defdb8768d

Sorry about that. But if your patch landed in patchwork, which it should, 
thenmaybe yours will be used in the end.

> 
> * Martin Michlmayr <tbm@cyrius.com> [2009-10-31 10:28]:
> > media/video/videobuf-dma-contig.c fails to compile on ARM Versatile
> > like this:
> >  | videobuf-dma-contig.c: In function ‘videobuf_dma_contig_user_get’:
> >  | videobuf-dma-contig.c:139: error: dereferencing pointer to incomplete type
> >  | videobuf-dma-contig.c:184: error: dereferencing pointer to incomplete type
> >  | make[8]: *** [drivers/media/video/videobuf-dma-contig.o] Error 1
> > 
> > Looking at the preprocessed source, I noticed that there was no definition
> > for struct task_struct.
> > 
> > Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
> > 
> > --- a/drivers/media/video/videobuf-dma-contig.c	2009-10-31 10:22:42.000000000 +0000
> > +++ b/drivers/media/video/videobuf-dma-contig.c	2009-10-31 10:24:40.000000000 +0000
> > @@ -19,6 +19,7 @@
> >  #include <linux/mm.h>
> >  #include <linux/pagemap.h>
> >  #include <linux/dma-mapping.h>
> > +#include <linux/sched.h>
> >  #include <media/videobuf-dma-contig.h>
> >  
> >  struct videobuf_dma_contig_memory {

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

Re: [PATCH] videobuf-dma-contig.c: add missing #include

[Martin Michlmayr]

* Guennadi Liakhovetski <g.liakhovetski@gmx.de> [2009-11-11 19:38]:
> > Are there any comments regarding the build fix I submitted?  This
> > issue is still there, as you can see at
> > http://www.xs4all.nl/~hverkuil/logs/Tuesday.log
> 
> Oh, I'm afraid, I've unwillingly stolen your patch:
> 
> http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=d5defdb8768d
> 
> Sorry about that. But if your patch landed in patchwork, which it should, 
> thenmaybe yours will be used in the end.

Yes, it's here: http://patchwork.kernel.org/patch/56763/

Maybe you can add your acked-by.
-- 
Martin Michlmayr
http://www.cyrius.com/

Re: [PATCH] videobuf-dma-contig.c: add missing #include

[Guennadi Liakhovetski]

On Sat, 31 Oct 2009, Martin Michlmayr wrote:

> media/video/videobuf-dma-contig.c fails to compile on ARM Versatile
> like this:
>  | videobuf-dma-contig.c: In function ‘videobuf_dma_contig_user_get’:
>  | videobuf-dma-contig.c:139: error: dereferencing pointer to incomplete type
>  | videobuf-dma-contig.c:184: error: dereferencing pointer to incomplete type
>  | make[8]: *** [drivers/media/video/videobuf-dma-contig.o] Error 1
> 
> Looking at the preprocessed source, I noticed that there was no definition
> for struct task_struct.
> 
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>

Mauro, if you decide to apply this one and then only take missing parts 
from 
http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=d5defdb8768d 
then you can add my

Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

to this one.

> 
> --- a/drivers/media/video/videobuf-dma-contig.c	2009-10-31 10:22:42.000000000 +0000
> +++ b/drivers/media/video/videobuf-dma-contig.c	2009-10-31 10:24:40.000000000 +0000
> @@ -19,6 +19,7 @@
>  #include <linux/mm.h>
>  #include <linux/pagemap.h>
>  #include <linux/dma-mapping.h>
> +#include <linux/sched.h>
>  #include <media/videobuf-dma-contig.h>
>  
>  struct videobuf_dma_contig_memory {
> 
> -- 
> Martin Michlmayr
> http://www.cyrius.com/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/