public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean-Francois Moine <moinejf@free.fr>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Antonio Ospite <ospite@studenti.unina.it>, linux-media@vger.kernel.org
Subject: Re: [RFC, PATCH] gspca: implement vidioc_enum_frameintervals
Date: Thu, 19 Nov 2009 12:48:21 +0100	[thread overview]
Message-ID: <20091119124821.25524a23@tele> (raw)
In-Reply-To: <4B0527D9.8000800@redhat.com>

On Thu, 19 Nov 2009 12:11:21 +0100
Hans de Goede <hdegoede@redhat.com> wrote:

> Hmm, I see now upon expecting the code that the driver does actually
> support setting the framerate, but what I see does not seem
> to match your patch, the driver seems to support 50, 40, 30 and 15
> fps, where as your patch has:
> 
> static int qvga_rates[] = {125, 100, 75, 60, 50, 40, 30};
> static int vga_rates[] = {60, 50, 40, 30, 15};

Hi,

The function set_frame_rate() is changed in my test repository.

Regards.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

  reply	other threads:[~2009-11-19 11:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17 10:41 [RFC, PATCH] gspca: implement vidioc_enum_frameintervals Antonio Ospite
2009-11-17 10:57 ` Michael Trimarchi
2009-11-19  8:08 ` Hans de Goede
2009-11-19  9:00   ` Michael Trimarchi
2009-11-19  9:27     ` Hans de Goede
2009-11-19 10:37   ` Antonio Ospite
2009-11-19 11:11     ` Hans de Goede
2009-11-19 11:48       ` Jean-Francois Moine [this message]
2009-12-01 15:39 ` [PATCH] " Antonio Ospite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091119124821.25524a23@tele \
    --to=moinejf@free.fr \
    --cc=hdegoede@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=ospite@studenti.unina.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox